Add initial code for recursion limit #4729

Leo-Besancon · 2024-07-16T06:35:49Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

…xecution (#4710) * Requery bytecode * cargo fmt

* Improve async message checks * Change checks for async messages * Add unit tests

…ge (#4715) * Take again the speculative changes after async message cancellation * use .apply() to merge the two LedgerChanges * Fix: we cannot combine two ledger changes with apply * avoid cloning the changes * Remove comment

* fix open rpc spec (#4716) * Add eliminated_new_messages in eliminated_msg --------- Co-authored-by: Modship <yeskinokay@gmail.com>

codecov · 2024-07-16T11:45:26Z

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (mainnet_2_3@880eec7). Learn more about missing BASE report.

Files	Patch %	Lines
massa-node/src/main.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##             mainnet_2_3    #4729   +/-   ##
==============================================
  Coverage               ?   71.78%           
==============================================
  Files                  ?      291           
  Lines                  ?    51642           
  Branches               ?        0           
==============================================
  Hits                   ?    37069           
  Misses                 ?    14573           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/ci.yml

massa-execution-exports/src/settings.rs

massa-execution-worker/src/execution.rs

massa-execution-worker/src/interface_impl.rs

Leo-Besancon · 2024-08-05T09:07:02Z

Oops @damip , seems like the rebase did not work. Here is the compare link: e25f021...2cc4a17

massa-execution-worker/src/speculative_async_pool.rs

massa-models/src/config/constants.rs

sydhds

All good but can we find a place where we explain why we need this to be implemented?

massa-execution-exports/src/test_exports/config.rs

massa-execution-exports/src/settings.rs

massa-execution-worker/src/tests/scenarios_mandatories.rs

Leo-Besancon and others added 10 commits July 2, 2024 17:29

Asc message execution - requery message bytecode after each message e…

04ed29c

…xecution (#4710) * Requery bytecode * cargo fmt

fix call stack inconsistency (#4709)

52814d4

Improve async message checks (#4706)

b64e360

* Improve async message checks * Change checks for async messages * Add unit tests

Fix async msg same slot (#4718)

880eec7

* fix open rpc spec (#4716) * Add eliminated_new_messages in eliminated_msg --------- Co-authored-by: Modship <yeskinokay@gmail.com>

Add initial code for recursion limit

e25f021

Latest runtime

9c13a14

Run CI on PRs based on mainnet_2_3

c0f3a0a

fmt

57bf59d

Fix config and add UTs

ad071b5

Leo-Besancon marked this pull request as ready for review July 16, 2024 10:08

Leo-Besancon requested a review from sydhds July 16, 2024 10:18

Update scenarios_mandatories.rs

fb20aec

sydhds reviewed Jul 16, 2024

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

massa-execution-exports/src/settings.rs Outdated Show resolved Hide resolved

Review comments (CI for all branches starting with "mainnet_" + comment)

7c7c32f

sydhds approved these changes Jul 17, 2024

View reviewed changes

Leo-Besancon requested a review from damip July 17, 2024 09:23

Update ci.yml

2cc4a17

Leo-Besancon force-pushed the mainnet_2_3 branch from a44a2da to aa7efcf Compare July 17, 2024 09:40