Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAIN.2.4 #4774

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Update MAIN.2.4 #4774

merged 5 commits into from
Nov 22, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

Includes fix for as_abort

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon
Copy link
Collaborator Author

@damip the CI fails because we have not updated Rust target.
Should we cherry-pick this commit 149a6e1 ?

sydhds and others added 3 commits November 21, 2024 14:01
@sydhds @Leo-Besancon
Update rust version to 1.81 (#4750)
38b63c3 
* Update rust version to 1.81

* Cargo clippy & fmt pass

* Cargo clippy & fmt pass 2

* Cargo clippy & fmt pass 3

* Remove commented code
@bilboquet @Leo-Besancon
Fix outdated UT
69a8f67 
Signed-off-by: Jean-François <jfm@laposte.net>
@Leo-Besancon
Fix new clippy warnings
db50814
bilboquet
bilboquet approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with a not to big change set

@Leo-Besancon Leo-Besancon added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 1965bec Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet approved these changes

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leo-Besancon @bilboquet @sydhds