NewSlotExecutionOutputs filters #4834

modship · 2025-01-24T13:57:00Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

…ys_algo

Leo-Besancon · 2025-02-04T13:54:17Z

massa-grpc/src/stream/new_slot_execution_outputs.rs

+        });
+
+        if exec_output.events.0.is_empty() {
+            return None;


Make sure we want to return None and not return an empty Slot execution output instead (depending on usage)

Leo-Besancon

LGTM

modship and others added 30 commits January 6, 2025 11:56

add parameters

37ac28a

limit keys number in get_datastore_keys

3be3722

limit keys number in get_final_and_candidate_datastore_keys

6186c66

Fix counter

d23b22b

current_mip_version to get_status (#4803)

7910ef7

update config with max_datastore_keys_query (optional)

c04b002

use Bound, new proto and remove get_addresses count limit (JSON RPC)

22d80be

add jsonrpc endpoint

d8db758

setup public endpoint

af1999e

offset in get_final_and_candidate_datastore_keys

1174e42

rename offset to start_key

5c94529

fix limit keys

06f80f7

wrap api result to struct

1705251

add openrpc documentation

e7a4811

init algo

6c36b23

update algo

782e285

factor code

edcf9c0

update proto

a33a101

fix take

f68374d

debug

444db8a

fixes and make compile

8565b84

comment

f2ef010

fix test

0c3e88a

fix test

ea151e2

clippy

e3e055c

add config

39f1509

api : limit the number of queried addresses

539ab67

clippy type_complexity

1cdc63a

improve iteration

1daa4de

Fix panic over iter

fb6b0a6

modship added 10 commits January 15, 2025 12:18

Test(scan_datastore) : clean code

87e1d7d

Test(scan_datastore) : create more keys

1085372

Doc(openrpc) : update openrpc spec

84b2292

Fix(api) : endpoint url

49851ff

Update massa-execution-worker/src/tests/tests_scan_datastore.rs

565f63a

update runtime / proto-rs

b27756c

Merge commit 'a8559f467bd88ef25da406e0f1f6c19fdc68140d' into damir_ke…

15d57b9

…ys_algo

Merge commit 'd7c750c00ff90b7dd908babc562c77a31d97bf5c' into damir_ke…

fabd1ad

…ys_algo

first filter on event

d6aa29e

filter on event

0f9812d

modship linked an issue Jan 24, 2025 that may be closed by this pull request

Implement remaining filters on NewSlotExecutionOutputs #4443

Closed

modship added api Issues related to the API MAIN.2.6 p2 labels Jan 24, 2025

modship changed the base branch from mainnet_2_3 to damir_keys_algo January 24, 2025 13:58

modship added 6 commits January 24, 2025 15:13

ledger change filter

5029943

impl other filters

3e273da

allow multiple event filter in same request

5dd160a

other new slot exec output filters

d872525

Test(slot_outputs) : stream test + clippy

9c929a5

refactor

e27ff06

modship marked this pull request as ready for review February 3, 2025 15:34

modship requested a review from Leo-Besancon February 3, 2025 16:18

fix reset filter

48f80e7

modship added the blocked Issues that can't be done for now. label Feb 4, 2025

Leo-Besancon reviewed Feb 4, 2025

View reviewed changes

Leo-Besancon approved these changes Feb 4, 2025

View reviewed changes

modship changed the base branch from damir_keys_algo to main_2_6 February 4, 2025 14:28

Merge remote-tracking branch 'origin/main_2_6' into grpc_filters

451d754

modship merged commit a4caea0 into main_2_6 Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NewSlotExecutionOutputs filters #4834

NewSlotExecutionOutputs filters #4834

modship commented Jan 24, 2025

Leo-Besancon Feb 4, 2025

Leo-Besancon left a comment

NewSlotExecutionOutputs filters #4834

NewSlotExecutionOutputs filters #4834

Conversation

modship commented Jan 24, 2025

Leo-Besancon Feb 4, 2025

Choose a reason for hiding this comment

Leo-Besancon left a comment

Choose a reason for hiding this comment