Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: select the created account in the dropdown #321

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jun 5, 2023

This PR fixes a bug:

  • create a new account
  • at step 3, click on Skip
  • see in the drop-down account selection that it is not your newly created account

needs massalabs/ui-kit#168

@Thykof Thykof force-pushed the bugfix-dropdown-after-create-account branch from e878447 to e71ec8c Compare June 5, 2023 14:19
@Thykof
Copy link
Contributor Author

Thykof commented Jun 5, 2023

still to do: clean code, maybe the use effect is not necessary, maybe the options passed to the useRessource is not necessary, also the refetch

@Thykof Thykof added this to the Wallet#2 milestone Jun 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (07c9528) 41.54% compared to head (e71ec8c) 41.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files          15       15           
  Lines        1047     1047           
=======================================
  Hits          435      435           
  Misses        569      569           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Thykof Thykof changed the title select the created account in the dropdown bugfix: select the created account in the dropdown Jun 5, 2023
@Thykof Thykof marked this pull request as draft June 6, 2023 07:29
@Thykof Thykof force-pushed the bugfix-dropdown-after-create-account branch from e71ec8c to a603a40 Compare June 6, 2023 09:01
@Thykof
Copy link
Contributor Author

Thykof commented Jun 6, 2023

indeed, all these changes are useless, we only need massalabs/ui-kit#168

@Thykof Thykof force-pushed the bugfix-dropdown-after-create-account branch from a603a40 to 7f4bb0f Compare June 6, 2023 12:29
@Thykof Thykof marked this pull request as ready for review June 6, 2023 12:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof merged commit 9df8cb8 into main Jun 6, 2023
@Thykof Thykof deleted the bugfix-dropdown-after-create-account branch June 6, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants