Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix name operation type #1247

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix name operation type #1247

merged 1 commit into from
Oct 26, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Oct 26, 2023

attempt to fix #1131 by renaming the variables.

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a10d232) 25.27% compared to head (846e393) 25.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   25.27%   25.27%           
=======================================
  Files          25       25           
  Lines        1559     1559           
=======================================
  Hits          394      394           
  Misses       1152     1152           
  Partials       13       13           
Files Coverage Δ
pkg/node/sendoperation/rolls.go 66.66% <80.00%> (ø)
pkg/node/sendoperation/sendoperation.go 20.91% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof merged commit 06ae6cb into main Oct 26, 2023
@Thykof Thykof deleted the fix-name-operation-type branch October 26, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor DecodeOperationType and create an enum with the different operation types
2 participants