Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description in the call sc #1358

Merged
merged 1 commit into from
May 3, 2024
Merged

add description in the call sc #1358

merged 1 commit into from
May 3, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented May 2, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof
Copy link
Contributor Author

Thykof commented May 3, 2024

QA:

curl --location 'http://station.massa/cmd/executeFunction' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--data '{
  "nickname": "buildnet-fullpower",
  "name": "functionName",
  "at": "AU1MPDRXuR22mwYDFCeZUDgYjcTAF1co6xujx2X6ugoHeYeGY3B5",
  "async": false,
  "args": "",
  "coins": 0,
  "maxGas": "1",
  "expiry": 3,
  "fee": "10000000",
  "description": "this is the description"
}'

Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@Thykof Thykof merged commit 9dc70b0 into main May 3, 2024
15 checks passed
@Thykof Thykof deleted the add-description-sc branch May 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants