Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

154 https certificate #288

Merged
merged 4 commits into from
Dec 6, 2022
Merged

154 https certificate #288

merged 4 commits into from
Dec 6, 2022

Conversation

peterjah
Copy link
Contributor

No description provided.

@peterjah peterjah linked an issue Nov 22, 2022 that may be closed by this pull request
HTTPS certificate #154
Closed
@peterjah peterjah force-pushed the 154-https-certificate branch from fc8d71f to b6f6cc8 Compare November 22, 2022 14:38
@peterjah peterjah mentioned this pull request Nov 22, 2022
Closed
@peterjah peterjah force-pushed the 154-https-certificate branch 19 times, most recently from 08037ec to 9fc4996 Compare November 28, 2022 12:06
@0xMazout 0xMazout self-requested a review November 29, 2022 09:50
@peterjah peterjah force-pushed the 154-https-certificate branch from 9fc4996 to 89a6bd0 Compare November 29, 2022 13:49
@peterjah peterjah force-pushed the 154-https-certificate branch from d7da9b8 to 173dc7e Compare December 1, 2022 09:06
gregLibert
gregLibert suggested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍

int/api/server.go Outdated Show resolved Hide resolved
scripts/linux_install.sh Outdated Show resolved Hide resolved
scripts/linux_install.sh Outdated Show resolved Hide resolved
scripts/linux_install.sh Outdated Show resolved Hide resolved
scripts/macos_install.sh Outdated Show resolved Hide resolved
@peterjah peterjah force-pushed the 154-https-certificate branch from 173dc7e to be167fe Compare December 2, 2022 09:20
@peterjah peterjah requested a review from gregLibert December 2, 2022 09:21
@peterjah peterjah force-pushed the 154-https-certificate branch from be167fe to 867c605 Compare December 2, 2022 09:26
@peterjah peterjah force-pushed the 154-https-certificate branch from 867c605 to b781928 Compare December 2, 2022 13:41
gregLibert
gregLibert approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 good job!

@ASAPSegfault ASAPSegfault self-requested a review December 5, 2022 14:03
ASAPSegfault
ASAPSegfault approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@ASAPSegfault ASAPSegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly fine

@gregLibert gregLibert merged commit c2dc365 into main Dec 6, 2022
@gregLibert gregLibert deleted the 154-https-certificate branch December 6, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xMazout 0xMazout 0xMazout approved these changes

@gregLibert gregLibert gregLibert approved these changes

@ASAPSegfault ASAPSegfault ASAPSegfault approved these changes

Assignees

@peterjah peterjah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTPS certificate
4 participants
@peterjah @0xMazout @gregLibert @ASAPSegfault