Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve wallet import #329

Merged
merged 2 commits into from
Dec 9, 2022
Merged

solve wallet import #329

merged 2 commits into from
Dec 9, 2022

Conversation

SebastienValla
Copy link
Contributor

No description provided.

@SebastienValla SebastienValla linked an issue Dec 7, 2022 that may be closed by this pull request
BUG cannot use imported wallet #322
Closed
@B-Naoufal B-Naoufal requested review from B-Naoufal and removed request for B-Naoufal December 7, 2022 15:41
gregLibert
gregLibert suggested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I should have added a comment to clarify the seed concept...

pkg/wallet/wallet.go Outdated Show resolved Hide resolved
pkg/wallet/wallet.go Outdated Show resolved Hide resolved
gregLibert
gregLibert approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏕️ 👏 Bug solved the boyscout way!

0xMazout
0xMazout approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@0xMazout 0xMazout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work :)

@gregLibert
Copy link
Contributor

@SebastienValla @SlnPons do we need to merge that ?

@gregLibert gregLibert added the action:merge this PR is ready to be merged label Dec 9, 2022
@gregLibert gregLibert merged commit 95e91a8 into main Dec 9, 2022
@gregLibert gregLibert deleted the 322-bug-cannot-use-imported-wallet branch December 9, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregLibert gregLibert gregLibert approved these changes

@0xMazout 0xMazout 0xMazout approved these changes

Assignees
No one assigned
Labels
action:merge this PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG cannot use imported wallet
3 participants
@SebastienValla @gregLibert @0xMazout