Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new dns contract #332

Merged
merged 4 commits into from
Dec 8, 2022
Merged

new dns contract #332

merged 4 commits into from
Dec 8, 2022

Conversation

SebastienValla
Copy link
Contributor

No description provided.

@SebastienValla SebastienValla linked an issue Dec 8, 2022 that may be closed by this pull request
New clean DNS for release testnet 17 #331
Closed
0xMazout
0xMazout approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@0xMazout 0xMazout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GOO MERGE

Thykof
Thykof approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a way to avoid to commit the wasm file here, like compile it in massa-as-contract, create a release with wasm file as artifact and here fetch it.

@B-Naoufal B-Naoufal self-requested a review December 8, 2022 16:43
B-Naoufal
B-Naoufal approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@B-Naoufal B-Naoufal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks sufficient.

gregLibert
gregLibert approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏕️ 👏

@gregLibert gregLibert merged commit 034fba9 into main Dec 8, 2022
@gregLibert gregLibert deleted the 331-new-clean-dns-for-release-testnet-17 branch December 8, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xMazout 0xMazout 0xMazout approved these changes

@Thykof Thykof Thykof approved these changes

@B-Naoufal B-Naoufal B-Naoufal approved these changes

@gregLibert gregLibert gregLibert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New clean DNS for release testnet 17
6 participants
@SebastienValla @0xMazout @Thykof @B-Naoufal @gregLibert @ASAPSegfault