280 website registry link does not take thyra running port into account #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjah
approved these changes
Dec 19, 2022
|
we will have to change again theses links for the support of https ! to be continued ! |
I'm not sure about that. We can remove the "http:" part and the web browser will figure out by itself which protocol it should use. By default, it will try to use I just tried it and it's working fine. I will push that fix. EDIT: You can see an example with the "Implicit protocol" here. |
gregLibert
suggested changes
Dec 19, 2022
Thykof
deleted the
280-website-registry-link-does-not-take-the-thyra-running-port-into-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.