Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds certutil for firefox with mkcert #408

Conversation

gregLibert
Copy link
Contributor

No description provided.

@gregLibert
Copy link
Contributor Author

@thomas-senechal can you test the installation script on MacOS and fix it if needed ?

@thomas-senechal
Copy link
Member

thomas-senechal commented Jan 17, 2023

@thomas-senechal can you test the installation script on MacOS and fix it if needed ?

Hi @gregLibert .
pkgutil --pkgs mainly returns Apple's packages. For example, my webbrowser, Discord, Postman and more are not shown by pkgutil while being in my /Applications/.
Checking directly in the /Applications/ directory is the only working way I found.

There might be a better way to check if a program is installed, but I don't know them and couldn't find them.

Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregLibert gregLibert merged commit 4cdb133 into main Jan 17, 2023
@gregLibert gregLibert deleted the 400-installation-fail-on-linux-when-configthyra-file-already-exists branch January 17, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants