Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

411 add wallet balance to thyra node object #418

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

SebastienValla
Copy link
Contributor

No description provided.

@SebastienValla SebastienValla linked an issue Jan 20, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙅 Code clarity can be improved.

pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
pkg/node/getBalanceOf.go Outdated Show resolved Hide resolved
pkg/node/fetchBalance.go Outdated Show resolved Hide resolved
@gregLibert gregLibert merged commit 0c60505 into main Jan 31, 2023
@gregLibert gregLibert deleted the 411-add-wallet-balance-to-thyra-node-object branch January 31, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wallet-balance to Thyra node object
5 participants