Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add <Input> component #46

Merged
merged 1 commit into from
May 5, 2023
Merged

add <Input> component #46

merged 1 commit into from
May 5, 2023

Conversation

mazmassa
Copy link
Contributor

@mazmassa mazmassa commented May 5, 2023

We are introducing the <Input> component.

Screenshot 2023-05-05 at 11 57 26

@mazmassa mazmassa changed the title add input field add <Input> component May 5, 2023
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-carabina maxime-carabina self-requested a review May 5, 2023 16:06
Copy link
Contributor

@maxime-carabina maxime-carabina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mazmassa mazmassa force-pushed the add-input-field branch from 4ea6f3e to 74ab030 Compare May 5, 2023 16:11
@mazmassa mazmassa merged commit 14c2196 into main May 5, 2023
@mazmassa mazmassa deleted the add-input-field branch May 5, 2023 16:12
pivilartisant pushed a commit that referenced this pull request May 5, 2023
@SlnPons
Copy link

SlnPons commented May 9, 2023

@mazmassa Niceeee job :)
Very cool to see this.

Compare to the design system, I can't see the "hover" mode. Did you remove it from the 1st iteration on purpose?

@mazmassa
Copy link
Contributor Author

mazmassa commented May 9, 2023

@mazmassa Niceeee job :) Very cool to see this.

Compare to the design system, I can't see the "hover" mode. Did you remove it from the 1st iteration on purpose?

I can't see the "hover" mode

Maybe you should set the dark mode because in light is soft the change and hard to see it. Normally it's there: https://github.com/massalabs/ui-kit/assets/126461030/7889f57a-4d4c-4efc-9893-1ece42b3e44b

Did you remove it from the 1st iteration on purpose?

Sorry but I haven't got your point here! 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants