Updated Makefile to reflect common structure

[massenz]

Summary by OpenAI

Release Notes:

• Refactor: Updated project structure and Makefile for consistency.
• New Feature: Added YQ installation step and enhanced Dockerfile.
• Documentation: Included common.mk with shared build rules.

"Code refactored, structure aligned,
YQ installed, Dockerfile defined.
Documentation improved, rules shared,
Project setup now better prepared."

[github-actions]

🤖 OpenAI

Thank you for letting me participate in the code review.

High-Level Summary:

The pull request updates various files related to the project structure. Changes include adding YQ installation, updating Dockerfile, incorporating common build and test rules from common-utils, and enhancing the Makefile with color codes, platform management, versioning, certificates, Dockerfile paths, and a help target.

File	Summary
.github/workflows/test.yaml	Added YQ installation step, renamed make gencert to make certs, and removed CLI test with a TODO comment.
docker/Dockerfile	Updated Dockerfile to use golang:1.22, added yq download and make build commands.
thirdparty/README.md	Added common.mk makefile with common build and test rules from common-utils repository to thirdparty/README.md.
thirdparty/common.mk	Added color codes, platform management, versioning, certificates, Dockerfile paths, and a help target to the Makefile. Check for yq installation and settings.yaml presence.

---

Chat with 🤖 OpenAI Bot (@openai)

• Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
• Invite the bot into a review comment chain by tagging @openai in a reply.

---

Files ignored due to filter (2)

Ignored files

• docker/compose.yaml
• settings.yaml

[github-actions]

🤖 OpenAI

Reviewing existing code in: docker/Dockerfile

The existing code in the docker/Dockerfile has a few issues that should be addressed:

1. The base image is specified as golang:1.21, but the comment mentions using golang:1.22. This inconsistency should be resolved.
2. The comment about using the Ubuntu image due to errors with other images should be clarified or updated for accuracy.
3. The apt-get update and apt-get install ca-certificates -y commands should be combined into a single RUN instruction for better layer caching efficiency.
4. The HEALTHCHECK command timeout value of 200ms seems very low and might need adjustment for practical use.

Please let me know if you would like more details on any of these points.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud