This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
DP-4325 Final Patterns Documentation #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 26, 2017 13:18
* DP-4080 - Versioning - first draft * Dp-4080 - let's try that again after saving the file. * DP-4080 - Versioning - updating Major version text * Second Draft * DP-4080 - Versions - Third draft with examples versions * DP-4080 - Version - reducing importance of Terms * DP-4080 - Version - Edits after reviewing. * DP-4080 - Versions - missed a few * DP-4080 - Versions - Weird copy and paste issue. * DP-4080 - Tweak to Minor version description * DP-4080 - Version Docs - fourth version * DP-4080 - Version doc - version 5
added 15 commits
August 15, 2017 16:13
added 6 commits
August 17, 2017 17:03
jesconstantine
approved these changes
Sep 10, 2017
There was a problem hiding this comment.
Thank you @legostud ! I have some quick thoughts / comments but I think this one is good to go as well!
| href: | ||
| type: string (url) / required | ||
| info: | ||
| type: string (adds more description to the link) / optional |
There was a problem hiding this comment.
I think for accessibility, this variable should be required - thoughts?
| @@ -1,8 +1,9 @@ | |||
| {% set arrowButton = arrowNav.arrowButton %} | |||
|
|
|||
| <section class="ma__arrow-nav {{ arrowButton.direction ? 'ma__arrow-nav--' ~ arrowButton.direction : '' }}"> | |||
| {% include "@atoms/01-buttons/arrow-button.twig" %} | |||
There was a problem hiding this comment.
Is there a way to relate the arrow button to the arrow nav title/link content? Curious how a screenreader would announce this here...
| @@ -0,0 +1,27 @@ | |||
| ### Description | |||
| List of links that can be rendered stack or as two columns | |||
There was a problem hiding this comment.
Could this pattern be a variant of a link list organism?
There was a problem hiding this comment.
Nevermind - I see this is done in a later PR! 👍
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Patterns used on the Homepage, Error Page and Transition Page. A few other Patterns that were missed or that weren't used on a page were updated as well.
Atoms:
Molecules:
Organisms:
Templates:
Pages: