Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

DP -825 board org accordion #842

Merged
merged 9 commits into from
Jun 11, 2018
Merged

DP -825 board org accordion #842

merged 9 commits into from
Jun 11, 2018

Conversation

isaacchansky
Copy link
Contributor

@isaacchansky isaacchansky commented May 21, 2018

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

This PR adds a new organism 'teaser listing group' to wrap multiple teaser listings in a single accordion behavior.

Related Issue / Ticket

Steps to Test

  1. View http://localhost:3000/?p=pages-organization-boards and confirm that the first 8 items show, and the rest are behind an accordion.
  2. View http://localhost:3000/?p=organisms-teaser-listing-group-showing-few-items and confirm that only 4 items are show, with the rest behind the accordion

Impacted Areas in Application

  • ADDED: @organisms/by-author/teaser-listing-group

Copy link
Contributor

@edwardchan edwardchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@edwardchan edwardchan force-pushed the DP-8825-board-org-accordion branch from c56cc0b to 0fc8985 Compare May 23, 2018 19:55
@isaacchansky isaacchansky merged commit 84a6e1a into dev Jun 11, 2018
isaacchansky added a commit that referenced this pull request Jun 11, 2018
isaacchansky added a commit that referenced this pull request Jun 26, 2018
* dev:
  DP-8804: Update Google Maps API to fix deprecation warning (#868)
  Updated the package.json version to 5.29.0
  Removed changelogs txt files for 5.29.0
  Added release notes for 5.29.0
  DP-9017  image placement on guide pages using focal point (#850)
  DP-9243: MF fix info details to show contact and related in sidebar as well as bottom on desktop (#860)
  DP-9297: Remove alt value from the state seal (#865)
  Update JS to hide toggle if # of items is less than totalShown.
  Fix invalid JSON.
  DP-9146: merge and clean  up changes
  DP-9146: use image src instead of image true
  Updated the package.json version to 5.28.0
  Removed changelogs txt files for 5.28.0
  Added release notes for 5.28.0
  DP -825 board org accordion (#842)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants