React/deprecate press teaser #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix contrast none * rename * cleanup unncessary styles * remove active style to fix space key issue * style lint * add changelog * consolidate changelog
* set up iframe and tableau iframe in figure * test edit * add Tableau libraries to /_meta/_01-foot.twig. * set up dataviz sample pages * set up breakpoint of 1025px * set up size values for dataviz * update sample pages * update figure template * layout edit * test edit * test edit 2 * tableau width settings * full page style set up * no side column content sample setup * add changelog for DP-17483 * add PR# to changelog * extend the sample content * correct html tag for stats * add sample page for info details section * correct markup for the stat's container * set up a sample page for info details section container * set up a section for rich text content * top margin adjustment with .ma__rich-text__container and nested comp heading * h2 padding adjustment with rich text * adjustment for .ma__rich-text__container * precontent container spacing adjustment * spacing adjusemtn with rich text section to match .ma__rich-text as a section container * test change * format adjustment * format adjustment * guide page rich text adjustment * richtext spacing adjustment in .ma__split-columns__column * test edit * test edit * rich text container related adjusement * top margin adjustment with div.rich-text * remove notes * format fix * clean up main figure template * clean up test comments * set up figure template for image * clean up image figure * set up iframe figure template * class value adjustment * adjust sample pages * set up dataviz figure template * adjust classes * clean up * update figure template * Implement some of the restructuring suggestions * Use block form of include for figure--image.twig * Also render figure--iframe content using block include * size property adjustment for figure * adjust size property for sample pages * remove unused file * Updating reference screenshots with dataviz * add wrapping class to figure * add wrapping style to figure * update samples * clean up sample pages * fix format * set wrap value if align has a value for figure image. * adjust sample pages for text wrapping with figure image * Updating dataviz sample reference screenshots * remove alignment class with size option of x-large * update caption sample content to include a link * add change log for DP-17634 * Updating reference screenshots for dataviz caption content change * margin adjustment * remove makeshift 1 col display and update json with DP-17625 change * update json with with DP-17625 change * clean up makeshift selectors * clean up comments * set figure width to 100% for page width 481 -620px * update figure with for window size 621px~ * adjustment for x-large with side column layout * right rail layout width change * modify last child element bottom margin in figcaption * test code * add non tableau figure content selector for sizing * adjust figure caption content margin * adjust 50% width to accommodate 2 figure containers side by side in a row * add x-large sample with side column * test code with tableau iframe width reset * add a condition to check if the page has a side column * remove top and bottom padding from elements in figure caption * clean up test comments * remove dataviz specific selector for figure * modify positioning of pull quote eyebrow * fix lint error * Updating reference screenshots * fix existing figure style * Updating reference screenshots * fix figure margin in ma__information-details__pre-content-media * Updating reference screenshots * remove vertical paddings for full width from pre-existing figure content * Updating reference screenshots * fix alignment for figure alingment samples * change sample for figure dataviz Co-authored-by: Rob Bayliss <rob@lastcallmedia.com>
* fix Octokit * temporarilty change cron time to 12pm tuesday to test the release hotfix
Release 9.49.3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
component: PressTeaser
description: Remove from package. (#)
issue: DP-17833
impact: Major