-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix site missing styles #1100
Merged
clairesunstudio
merged 1 commit into
assets-integration-branch
from
assets-integration-branch--site-style-fix
Jun 25, 2020
Merged
fix site missing styles #1100
clairesunstudio
merged 1 commit into
assets-integration-branch
from
assets-integration-branch--site-style-fix
Jun 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurrayatwork
approved these changes
Jun 25, 2020
clairesunstudio
added a commit
that referenced
this pull request
Jun 26, 2020
* DP-18263: Adds new assets package. (#1037) * DP-18263: Adds new assets package. * DP-18263: Removes stylelint ignore for dist directory. * DP-18263: Updates package name. * DP-18263: Updates circleci scripts for assets. * DP-18263: Fixes stylelint bug. * DP-18263: Updates lockfile to reflect package name change, fixes test script. * DP-18263: Moving static assets to static directory. (#1042) * DP-18263: Assets integration Branch: package version bump. (#1046) * DP-18263: Bumping mayflower-assets version. * Update assets/package.json Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Assets integration: Remove Bourbon requirement from assets package. (#1051) * DP-18263: Removes the dependency on bourbon. * Updates README, version bump. * Assets Integration Branch: React Support with Mayflower Assets Package (#1047) * DP-18263: Adds support for assets package with react. * DP-18263: Updates react package to use latest mayflower-assets package, removes debugging in storybook config. * Update react/.storybook/main.js * DP-18263: Adds .env file for react. * DP-18263: Fixes bugs related to fonts, layouts. Removes bourbon and bourbon neat dependencies. * DP-18263: Fixes stylelint errors for mayflower-assets. * DP-18263: Updates mayflower-assets package. * DP-18263: Fixes visual regression on HeaderSearch component. * Assets Integration: Patternlab (#1052) * DP-18263: Adds support for mayflower-assets package to patternlab. * DP-18263: Fixes bug caused by not waiting for files to copy before processing them for building patternlab. * DP-18263: Removes bourbon and bourbon neat from patternlab. * DP-18740: Integrates React/Storybook with Assets Package (#1064) * 18740: Integrates react package with new assets package. * DP-18740: Removes build css / watch css steps. * DP-18740: Updates files to be symlink. * DP-18740: Removes babel config from nwb, combines rules for storybook babel processing. * DP-18740: Removes css, style, sass loaders in package. * DP-18740: Updates react_test job to copy docs directory into image. * DP-18740: Fixes bug with backstop custom script failing to find symlink. * Assets integration: Remove style imports from react components. (#1073) * Adds component styles to styles directory. * Removes direct importing of styles in react components. * Updated gatsby site to support new mayflower-react. * Removes react style files from component directories. * Adds back missing ContactGroup import. * Adds missing styles for form component. * WIP. * Updated react components to document required styles. * Switches build to use gulp instead of NWB. * Removes NWB, react-scripts/CRA. * Cleans up npm scripts. * Updating mayflower-react version to 10, fixes bug with gatsby site related to package version. * Fixes eslint bug caused by babel-eslint plugins. * Removing babel-eslint to fix broken builds. * Reverting update of babel-eslint to fix bugs. * Fixes gatsby site to handle new dist/ directory from react. * Adds missing mayflower-react path to sass, adds auto eslint fixes. * Adds changelog file, updates gatsby site layout styles to remove duplicates. * Updated changelog text. * Cleans up code in storybook main file. * format changelog * format changelog Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Fixes remaining lint errors. (#1083) * Fixes bad pathing from merge conflicts. * Fixes regression on DecorativeLink. * Adding gulpfile to eslint ignore list. * Assets integration update backstop final (#1087) * Adds updated react backstop reference images. * approve patternlab screenshots * Removing files to fix conflicts with merge. * Puts back conflicitng files using assets-integration-branch as source. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Assets integration: Upgrades React, Patternlab, Gatsby to node 12. (#1085) * Upgrades node to v12 for react, gatsby site. * Updates node version to 12 for react circleci test. * Updates patternlab to node v12. * Assets integration: Fix React ES6 Exports (#1098) * Fixes ES Module exports to add file extensions. * WIP fix for react exports. * Revert "WIP fix for react exports." This reverts commit 57c0b64. * fix site missing styles (#1100) * Removes package exports and switches main to commonjs version. (#1101) * update mayflower-assets * Updating react circleci cache. * approve screenshots vertical spacing due to clearfix * approve react backstop screenshots * publish mayflower-react 10.0.0-alpha Co-authored-by: Minghua Sun <clairesunstudio@gmail.com>
clairesunstudio
added a commit
that referenced
this pull request
Oct 26, 2020
* React/dp 17982 replace rich text component (#1006) * swap out richtext to be a wrapper component * remove press teaser * add changelog * allow render raw html as children * add story and documentation * update richtext screenshots * address comments * add knob to conditionally pass children * move knob out of props * conditional knob * address feedback * add changelog * remove press teaser * React/deprecate general teaser (#1050) * add changelogs * remove General Teaser * refactor teaser listing * wip remove general teaser * add genteaser classnames to listing styles * add genteaser classnames to listing styles * add back listing items * remove unnecessary contained prop * change prop to coumns * create story to show more option * convert to use button with icon * cleanup * add changelog * add documentation * add new screenshots * cleanup and convert to functional component * Update react/src/components/organisms/TeaserListing/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * remove teaser * add to changelog * fix classname Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * React/dp 18576 deprecate input text type ahead (#1066) * deprecate and remove org selector * remove pressfilters * fix using input text fuzzy in typeAheadDropdown * prevent onSuggestionClick to trigger without a match * switch out input text typeahead in filterbox * remove input text typeahead * Update react/src/components/forms/InputTextFuzzy/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Update react/src/components/forms/TypeAheadDropdown/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * DP-18263: Adds new assets package. (#1037) (#1039) * DP-18263: Adds new assets package. (#1037) * DP-18263: Adds new assets package. * DP-18263: Removes stylelint ignore for dist directory. * DP-18263: Updates package name. * DP-18263: Updates circleci scripts for assets. * DP-18263: Fixes stylelint bug. * DP-18263: Updates lockfile to reflect package name change, fixes test script. * DP-18263: Moving static assets to static directory. (#1042) * DP-18263: Assets integration Branch: package version bump. (#1046) * DP-18263: Bumping mayflower-assets version. * Update assets/package.json Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Assets integration: Remove Bourbon requirement from assets package. (#1051) * DP-18263: Removes the dependency on bourbon. * Updates README, version bump. * Assets Integration Branch: React Support with Mayflower Assets Package (#1047) * DP-18263: Adds support for assets package with react. * DP-18263: Updates react package to use latest mayflower-assets package, removes debugging in storybook config. * Update react/.storybook/main.js * DP-18263: Adds .env file for react. * DP-18263: Fixes bugs related to fonts, layouts. Removes bourbon and bourbon neat dependencies. * DP-18263: Fixes stylelint errors for mayflower-assets. * DP-18263: Updates mayflower-assets package. * DP-18263: Fixes visual regression on HeaderSearch component. * Assets Integration: Patternlab (#1052) * DP-18263: Adds support for mayflower-assets package to patternlab. * DP-18263: Fixes bug caused by not waiting for files to copy before processing them for building patternlab. * DP-18263: Removes bourbon and bourbon neat from patternlab. * DP-18740: Integrates React/Storybook with Assets Package (#1064) * 18740: Integrates react package with new assets package. * DP-18740: Removes build css / watch css steps. * DP-18740: Updates files to be symlink. * DP-18740: Removes babel config from nwb, combines rules for storybook babel processing. * DP-18740: Removes css, style, sass loaders in package. * DP-18740: Updates react_test job to copy docs directory into image. * DP-18740: Fixes bug with backstop custom script failing to find symlink. * Assets integration: Remove style imports from react components. (#1073) * Adds component styles to styles directory. * Removes direct importing of styles in react components. * Updated gatsby site to support new mayflower-react. * Removes react style files from component directories. * Adds back missing ContactGroup import. * Adds missing styles for form component. * WIP. * Updated react components to document required styles. * Switches build to use gulp instead of NWB. * Removes NWB, react-scripts/CRA. * Cleans up npm scripts. * Updating mayflower-react version to 10, fixes bug with gatsby site related to package version. * Fixes eslint bug caused by babel-eslint plugins. * Removing babel-eslint to fix broken builds. * Reverting update of babel-eslint to fix bugs. * Fixes gatsby site to handle new dist/ directory from react. * Adds missing mayflower-react path to sass, adds auto eslint fixes. * Adds changelog file, updates gatsby site layout styles to remove duplicates. * Updated changelog text. * Cleans up code in storybook main file. * format changelog * format changelog Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Fixes remaining lint errors. (#1083) * Fixes bad pathing from merge conflicts. * Fixes regression on DecorativeLink. * Adding gulpfile to eslint ignore list. * Assets integration update backstop final (#1087) * Adds updated react backstop reference images. * approve patternlab screenshots * Removing files to fix conflicts with merge. * Puts back conflicitng files using assets-integration-branch as source. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Assets integration: Upgrades React, Patternlab, Gatsby to node 12. (#1085) * Upgrades node to v12 for react, gatsby site. * Updates node version to 12 for react circleci test. * Updates patternlab to node v12. * Assets integration: Fix React ES6 Exports (#1098) * Fixes ES Module exports to add file extensions. * WIP fix for react exports. * Revert "WIP fix for react exports." This reverts commit 57c0b64. * fix site missing styles (#1100) * Removes package exports and switches main to commonjs version. (#1101) * update mayflower-assets * Updating react circleci cache. * approve screenshots vertical spacing due to clearfix * approve react backstop screenshots * publish mayflower-react 10.0.0-alpha Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Mayflower v10 with latest develop (#1106) * [assets] font weights as variables (#1054) * switch to use variables * revert paths * fix * add changelog * fix var * add lightest var * add lightest var * DP-18543 Update jquery (#1048) * Update jquery from 3.4.0 to 3.5.1 * Add changelog for DP-18543 Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * Hotfix/fix changelog (#1060) * fix release blockers * advance cron time * Changelog update and remove old changelog files * DP-18704 Solve screen flicker issue observed on Mass.gov error pages (#1065) * add the flikering issue fix * add changelog for DP-18704 * prevent the fix to be overridden * Changelog update and remove old changelog files * add fonts for vietnamese (#1068) * add fonts for vietnamese * changelog * Changelog update and remove old changelog files * Update some node package dependencies (#1069) Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * Master (#1079) * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * DP-15628 Expand a hot spot of TOC link to its parent container (#1070) * add data attribute to identify target link parent containers * add expandClickable.js * add 'data-link' to .ma__sticky-toc__link * set up toc-hierarchy and download-link with clickable.js * add visual cue at hover for the toc item link container * add comment * fix typo * test edit * remove test edit * set up toc link parent container clickable * sticky nav title fix test edit 1 * put back the missing empty line * remove test code * add test code * test edit * fix the toc title overwrapping on toc links in the flyout * add comment * expand clickable area in mobile flyout sticky toc * make the icon clickable in mobile toc * set visual indicator for link at hover on parent container of a link in toc * add changelog for DP-15628 * fix lint error * clean up comments * clean up comments * backstop error fix * fix lint error * adding a feature to update .ma__sticky-toc__current-section content with clicking .ma__sticky-toc__link and icon, fix the link feature with clicking icon * remove side margins from toc item container to make entire container clickable * put TOC item link icon behind the item container * remove test comments * hover style adjustment for child li of .ma__toc--hierarchy__accordion-content * DP-18940 Key message background image (#1082) * Replace style tags in key-message template with inline * Add changelog for DP-18940 * Fix scss for stylelint Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * Use node for HelperText message property (#1080) * Use node for HelperText message property * Add changelog entry for helpertext_proptype * Update changelogs/helpertext_proptype.yml Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * DP-17612 Fix org search styles for Firefox browser (#1088) * Bump up z-index for open search form * Add changelog for DP-17612 Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * update changelog for release 9.52.0 * Apply suggestions from code review * DP-19085 google map (#1089) * modify google-map.twig to print googleMap.link.info. * modify googleMap.link.info value to be a location name * modify googleMap.link.info value to be a location name * add condition to remove aria-hidden and role attributes when it's static. * add changelog for DP-19085 * Update npm packages (#1093) Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * DP-17404 relationship indicator change2 (#938) * relationship indicator changes from DP-17138 * change the label for the secondary set of the relationship indicator * adjust the width of each set and spacing * add changelog for DP-17150 * add pr# to the changelog * update the secondary label of the relationship indicator * update backstop reference screenshots * remove unrelated changes * correcct markup of relationshipIndicators.secondary button wrappter * fix keyboard trap with the expanded more button * fix the relationship indicator content * updating reference screenshots * add 'go to next item' commands for screen readers * merge wrapped-link into relationship-indicators * remove the focus order feature to replace it with CSS * merge wrapped-link into the template and adjust the loop to render the button as the second item. * set the flex box order to the button for logical focus order when the list is expanded. * move the table of content overlay section to below the relationship indicator in binder internal page. * test edit * match the markup with Drupal * test edit * spacing test edit * remove test code * match spacing with prod version * put back missing mobileNav.js * add changelog for DP-17404 * remove padding top from breadkpoint 911px min * add PR number to changelog * update backstop reference screenshots * update reference screenshots * adjust spacing and clean up spacing styles * adjust specificity in css * decrease bottom margin of terms and button * test edit * adjustment for drupal * update json files * Updating reference screenshots * adjust bottom margins * add condition to check if data exists. * fix typo * correct tag for label * replace taxonomy terms output format with relationship indicator * modified display conditions * comment out existing taxonomyTerms output * adjust a display condition of .ma__page-header__tags content * Update backstop reference screenshots * adjust label bottom margin * Updating reference screenshots * content clean up with resolving merge conflicts * fix lint errors * lint fix 2 * expand focus indicator border line on .ma__relationship-indicators button * adjust the condition to add class for RI unit * remove bottom border from relationship indicator in topic page to match Drupal implementation * Updating reference screenshots * adjust padding top in the screen width less than 480px to 20px * adjust space between the relationship indicator and the banner in the width 781-910px * Update reference screenshots for mobile displays * remove unnecessary file * run release branch at 3:20 EST (#1095) * Changelog update and remove old changelog files * Fixes lint error caused by bad merge conflict fix on elements.scss. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> Co-authored-by: danstafford <danstafford@users.noreply.github.com> Co-authored-by: Dan Stafford <dan@lastcallmedia.com> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: Rob Bayliss <rfbayliss@gmail.com> * Revert "Mayflower v10 with latest develop (#1106)" (#1107) This reverts commit f3b1266. * Fixes back merge resolution with elements.scss. * Bumps mayflower-assets version. * Updates lockfiles for new mayflower-assets version. * Fixes back merge resolution for patternlab backstop reference images. * approve screenshots * Mayflower v10: Fixes merge conflicts with develop. (#1108) * [assets] font weights as variables (#1054) * switch to use variables * revert paths * fix * add changelog * fix var * add lightest var * add lightest var * DP-18543 Update jquery (#1048) * Update jquery from 3.4.0 to 3.5.1 * Add changelog for DP-18543 Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * Hotfix/fix changelog (#1060) * fix release blockers * advance cron time * Changelog update and remove old changelog files * DP-18704 Solve screen flicker issue observed on Mass.gov error pages (#1065) * add the flikering issue fix * add changelog for DP-18704 * prevent the fix to be overridden * Changelog update and remove old changelog files * add fonts for vietnamese (#1068) * add fonts for vietnamese * changelog * Changelog update and remove old changelog files * Update some node package dependencies (#1069) Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * Master (#1079) * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * DP-15628 Expand a hot spot of TOC link to its parent container (#1070) * add data attribute to identify target link parent containers * add expandClickable.js * add 'data-link' to .ma__sticky-toc__link * set up toc-hierarchy and download-link with clickable.js * add visual cue at hover for the toc item link container * add comment * fix typo * test edit * remove test edit * set up toc link parent container clickable * sticky nav title fix test edit 1 * put back the missing empty line * remove test code * add test code * test edit * fix the toc title overwrapping on toc links in the flyout * add comment * expand clickable area in mobile flyout sticky toc * make the icon clickable in mobile toc * set visual indicator for link at hover on parent container of a link in toc * add changelog for DP-15628 * fix lint error * clean up comments * clean up comments * backstop error fix * fix lint error * adding a feature to update .ma__sticky-toc__current-section content with clicking .ma__sticky-toc__link and icon, fix the link feature with clicking icon * remove side margins from toc item container to make entire container clickable * put TOC item link icon behind the item container * remove test comments * hover style adjustment for child li of .ma__toc--hierarchy__accordion-content * DP-18940 Key message background image (#1082) * Replace style tags in key-message template with inline * Add changelog for DP-18940 * Fix scss for stylelint Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * Use node for HelperText message property (#1080) * Use node for HelperText message property * Add changelog entry for helpertext_proptype * Update changelogs/helpertext_proptype.yml Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * DP-17612 Fix org search styles for Firefox browser (#1088) * Bump up z-index for open search form * Add changelog for DP-17612 Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * update changelog for release 9.52.0 * Apply suggestions from code review * DP-19085 google map (#1089) * modify google-map.twig to print googleMap.link.info. * modify googleMap.link.info value to be a location name * modify googleMap.link.info value to be a location name * add condition to remove aria-hidden and role attributes when it's static. * add changelog for DP-19085 * Update npm packages (#1093) Co-authored-by: Dan Stafford <dan@lastcallmedia.com> * DP-17404 relationship indicator change2 (#938) * relationship indicator changes from DP-17138 * change the label for the secondary set of the relationship indicator * adjust the width of each set and spacing * add changelog for DP-17150 * add pr# to the changelog * update the secondary label of the relationship indicator * update backstop reference screenshots * remove unrelated changes * correcct markup of relationshipIndicators.secondary button wrappter * fix keyboard trap with the expanded more button * fix the relationship indicator content * updating reference screenshots * add 'go to next item' commands for screen readers * merge wrapped-link into relationship-indicators * remove the focus order feature to replace it with CSS * merge wrapped-link into the template and adjust the loop to render the button as the second item. * set the flex box order to the button for logical focus order when the list is expanded. * move the table of content overlay section to below the relationship indicator in binder internal page. * test edit * match the markup with Drupal * test edit * spacing test edit * remove test code * match spacing with prod version * put back missing mobileNav.js * add changelog for DP-17404 * remove padding top from breadkpoint 911px min * add PR number to changelog * update backstop reference screenshots * update reference screenshots * adjust spacing and clean up spacing styles * adjust specificity in css * decrease bottom margin of terms and button * test edit * adjustment for drupal * update json files * Updating reference screenshots * adjust bottom margins * add condition to check if data exists. * fix typo * correct tag for label * replace taxonomy terms output format with relationship indicator * modified display conditions * comment out existing taxonomyTerms output * adjust a display condition of .ma__page-header__tags content * Update backstop reference screenshots * adjust label bottom margin * Updating reference screenshots * content clean up with resolving merge conflicts * fix lint errors * lint fix 2 * expand focus indicator border line on .ma__relationship-indicators button * adjust the condition to add class for RI unit * remove bottom border from relationship indicator in topic page to match Drupal implementation * Updating reference screenshots * adjust padding top in the screen width less than 480px to 20px * adjust space between the relationship indicator and the banner in the width 781-910px * Update reference screenshots for mobile displays * remove unnecessary file * run release branch at 3:20 EST (#1095) * Changelog update and remove old changelog files * Fixes back merge resolution with elements.scss. * Bumps mayflower-assets version. * Updates lockfiles for new mayflower-assets version. * Fixes back merge resolution for patternlab backstop reference images. * approve screenshots Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> Co-authored-by: danstafford <danstafford@users.noreply.github.com> Co-authored-by: Dan Stafford <dan@lastcallmedia.com> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: Rob Bayliss <rfbayliss@gmail.com> * Revert "Mayflower v10: Fixes merge conflicts with develop. (#1108)" (#1110) This reverts commit a172483. * Updates README for react package to reflect changes to development flow. (#1109) * Updates README for react package to reflect changes to development flow. * Update react/README.md Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Updates readme. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * add assets as peer dependency * add container styling and cleanup styles * move nvmrc to the root * set vars * styling * Moves mayflower-assets to be a dev dependency. * Removes logo import from SiteLogo component. * Changes SiteLogo to only render image if image src is set. * Removes site logo import from Header, Footer components. * Removes Header default alt text. * Update react/src/components/templates/NarrowTemplate/NarrowTemplate.stories.js * Updates version to alpha.1 * Changes SiteLogo to make siteName prop optional. * remove sitename from footerslim * Removes default prop value siteName from SiteLogo. * Adds descriptions to SiteLogo props. * Fixes typo in prop description for SiteLogo. * Update react/src/components/atoms/media/SiteLogo/index.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Removes sitelogo import from Footer, cleans up SiteLogo code. * Update react/src/components/atoms/media/SiteLogo/index.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update react/src/components/atoms/media/SiteLogo/index.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update react/src/components/organisms/Header/index.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * revert header slim story visual regression * Updates Error components, NarrowTemplate to support passing in custom sitelogo component. * Pulls in updated header-slim styling from develop. * Mayflower v10: Replace SVG Sprite Loader with SVGR Icons (#1123) * DP-19414: WIP for removing SVG sprites from Icon component. * Wraps up work for generating SVG Icons. * Ignores new icon-template file from lint. * Updates gatsby site to work with icon changes. * Fixes bugs with error components that prevented gatsby from building, misc bug fixes for console errors on gatsby site. * Update react/src/components/organisms/TeaserListing/TeaserListing.stories.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update react/.gitignore Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Renamed Icon components to be prefixed with Icon. * Adds back icon assets. * Fixes lint errors. * Updates build script to create icons. * Updates formatting for icon-template. * Fixes visual regressions. * approve screenshots * Updates Mayflower React to alpha.2. * Updated README for svg changes, yalc replacement for npm link, added changelog. * Update changelogs/DP-19414.yml Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * lint fix * lint fix * add google analytics * Revert "add google analytics" This reverts commit 45430aa. * publish mayflower-assets * upgrade mayflower assets package * update package lock for patternlab * approve patternlab backstop * approve react backstop * lint fix * Mayflower v10: Storybook 6.0 Upgrade (#1162) * Initial stable upgrade to storybook 6.0. * WIP. * Wraps up converting atoms. * WIP: Upgrades molecules to use controls. * WIP: Adds organisms, templates, pages CSF stories. * WIP: Adds misc stories to CSF/MDX format. * WIP: Misc bug fixes, adds HTML display on doc pages. * WIP: Fixes backstop. * Code cleanup, removes acorns dev dependencies, updates storybook. * Updates circle to run storybook extract. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * WIP: Fixes circleci react testing. * WIP: Fixes circleci react testing. * WIP: Fixes circleci react testing. * WIP: Updates eslint rules to ignore auto generated icons. * WIP: Changes backstop settings, fixes component docs. * WIP: Puts back backstop config for async capture limit. * Updates ButtonCopy logic, excludes it from backstop tests. * Updates title for Docs to component name, fixes ButtonWithIcon story. * Updates component propTypes comment structure, misc bug fixes for stories. * WIP. * WIP: Updates typography story name. * Round 2 code review fixes. * Updates form stories to work with CSF format and storybook docs. * Update react/src/components/forms/DateRange/DateRange.stories.js Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Removes un-needed portion of typography story. * Adds updated backstop screens. * Updates typograph story to remove story component. * Adds changelog. * Adds updated backstop files. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Mayflower v10 rush monorepo (#1195) * Updates gitignore file. * Adds Rush, PNPM support, WIP. * WIP: Fixes develop, build modes, updates circleci for rush and pnpm. * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP: Testing pnpx with rush * WIP * WIP * Moves patternlab to packages, fixes eslint bugs. * Fixes circleci pathing for monorepo. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Fixes circleci patternlab. * Installs node 12 with nvm. * Installs node 12 with nvm. * Updates patternlab image to use circleci provided image. * Updates patternlab image to use circleci provided image. * Updates patternlab image to use circleci provided image. * Updates patternlab image to use circleci provided image. * Updates patternlab image to use circleci provided image. * Installing aws on patternlab_deploy_branch workflow. * Installing aws on patternlab_deploy_branch workflow. * Installing aws on patternlab_deploy_branch workflow. * WIP. * Fixes react dependencies for pnpm. * Lint fixes. * Updates mayflower repo readme on using the monorepo. * Updates mayflower repo readme on using the monorepo. * Fixes gitignore rules that was breaking patternlab builds. * Fixes patternlab cache in circleci. * Fixes patternlab to use normalize again. * add to doc * update doc * add back package.json for auto release scripts * add commands at the root * fix * Adds support for running custom rush commands at root for starting sites, fixes circleci build. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci bugs. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Fixes circleci. * Updates README file on using rush and rushx commands. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Dp 20050 font switch (#1193) * noto inside fonts * wip * adjust body line height * import fonts * map font sizes * fine tune weights * move fonts into static folder * map font styles classes * fix variable mapping * cleanup * cleanup * adjust root fontsize * typography story wip; * hide preview control columns * fix * remove knobs addon * wip * clean up * fix empty canvas tag bug by setting default * edit * remove texta * remove texta * compile for multilingual scripts * simplify vf check * wip * add langs code * add language samples * import arabic and hebrew variable fonts and fix direction and alignment * remove textAlign in story * restructure font files * git change folder name casing * clean up * use system vars * add myanmar support * cleanup * add variable to control rtl directions * fix and render fonts in noto sans in docs * render RichText in noto sans, enable RichText to inherit other attributes * add simplified chinese * Revert "add simplified chinese" This reverts commit 1f08588. * fix richtext in story * edit * add changelog * remove forward * add default in react * separate out fontface mixin * refactor fonts scss * separate out vars and mixins * move global variables into variables.scss * add notes and cleanup * add condition for language support set fonts and fix patternlab * update comments * update docs and changelog * address comment to separate mixin files * update docs * DP-20050: Fixes circleci build for gatsby site. * DP-20050: Fixes circleci build for gatsby site. * DP-20050: Fixes lint errors. * approve react backstop * DP-20050: Updates backstop reference images. * Revert "DP-20050: Updates backstop reference images." This reverts commit 1e7ec2c. * approve screenshots Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com> * Patternlab/fix fonts paths (#1212) * remove texta references * make relative path * fix path * add layout scss * V10 fix radio button styles (#1214) * fix radio button styles * fine tune radio button group alignment * approve react backstop * approve patternlab backstop * Adds missing smoothscroll-polyfill package to patternlab package. * Updates lockfile for pnpm. * Fixes missing files from pulling in latest develop. * React/dp 19541 extend header slim (#1207) * allow passing custom skipNav * add utilityNav and mainNav render props * fix styles * add story * change story to pass in header search * fix stylelint * add changelog * make render props new components * convert SiteLogo prop * change proptype check for SiteLogo * Update react/src/components/organisms/HeaderSlim/index.js * make skipNav proptype a component instead of function * convert prop to node type * fix * lowercase props * change mainNav component to validate the proptype works properly * approve backstop images * Update packages/assets/scss/03-organisms/_header-slim.scss Co-authored-by: Steven Murray <smurrayatwork@gmail.com> Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com> Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Adds command to run react backstop with rush, updates headerslim backstop reference images. * React/dp 19539 footer slim multiple logos1 (#1208) * merge conflicts * remove obsolete file * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Update packages/react/src/components/organisms/FooterSlim/FooterSlim.stories.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * update phone to be anchor link * fix default story and update siteLogo type to node * address comments * fix narrow template vrt * fix error pages vrt * approve backstop images Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * fix * approve screenshots in patternlab * remove comment * Mayflower v10: display rendered styles (#1224) * WIP. * Adds support for displaying rendered styles and html for Header, HeaderSlim, Footer, FooterSlim components. * Branch cleanup. * Code cleanup. * Fixes performance issues caused by prettier formatting displayed css. * Fixes visual regressions. * Reduces the number of scss files for preview to work. * Updates pnpm lock file. * Updates preview component to use memoization on html display, removes unused prettier plugin. Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * remove unwanted comment in css code snippets * fix alerts spacing on mobile * add and fix changelogs * add missing changelogs * approve screenshots for alerts mobile fix * update readme Co-authored-by: Steven Murray <smurrayatwork@gmail.com> Co-authored-by: danstafford <danstafford@users.noreply.github.com> Co-authored-by: Dan Stafford <dan@lastcallmedia.com> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: Rob Bayliss <rfbayliss@gmail.com> Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put back missing color var to fix the error
Also added back missing layout styles