Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-20092 Fix menu issues affecting COVID-19 unemployment page with new global nav #1197

Merged
merged 2 commits into from
Oct 5, 2020
Merged

DP-20092 Fix menu issues affecting COVID-19 unemployment page with new global nav #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8da48
Added bind for tabbing function body truncation - DP-20092
tom-fleming Oct 2, 2020
9e5ad36
Added changelog
tom-fleming Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/DP-20092.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fixed:
- project: Patternlab
component: Header
description: Fixed global nav issues when text truncation enabled. (#1197)
issue: DP-20092
impact: Patch
6 changes: 3 additions & 3 deletions patternlab/styleguide/source/assets/js/helpers/truncateBodyText.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ var removeTruncation = function($el) {
* Make elements focusable or not focusable based on expansion/collapse
* of content area.
*/
var toggleTabindexes = function($focusableEls, expanded) {
var toggleTabindexes = (function($focusableEls, expanded, $) {
if(expanded) {
$focusableEls.each(function(i, el) {
var $el = $(el);
Expand All @@ -93,8 +93,8 @@ var toggleTabindexes = function($focusableEls, expanded) {

$el.attr('tabindex', '-1');
});
}
};
}
}).bind(undefined, jQuery);

/**
* Turn on truncation (if height requires it) based on previous calculations.
Expand Down