DP-23521 Front end enhancement for Breadcrumbs & Offered By, medium & small #1564
+477
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3521_breadcrumbs-mobile
…bile to be scrolled all the way to the right.
…ing breadcrumbs to be right scrolled.
…3521_breadcrumbs-mobile
…3521_breadcrumbs-mobile
|
@Javi-er this is what I am seeing in mobile for the breadcrumbs. I can see that the breadcrumbs are rendering when I inspect the page. |
@tom-fleming looks like that the mayflower branch is missing I think, can you double check? |
|
LGTM. After discussing with @Javi-er, we'll resolve PatternLab test issues in the integration branch. |
beto-aveiga
added a commit
that referenced
this pull request
Mar 15, 2022
* theming breadcrumbs and relationship indicators * Adjusting breadcrumbs and relationship indicator. * Create DP-23393.yml * adjusting padding * adjusting padding * group after x JS changes * Adjusting for DP-23442 * adjusting hover effect * Adjusted hover color * cleaning up, adding back padding * adjusted aria and margin * approving patternlab * approving pl differences * DP-23521 Front end enhancement for Breadcrumbs & Offered By, medium & small (#1564) * Adjusting for mobile * Adjusting for mobile * Adjusting gray color, reducing timeout. * Adjusting wobbly relationship indicators and making breadcrumbs on mobile to be scrolled all the way to the right. * Adjusting breadcrumbs shakiness, indicators floating and details. Making breadcrumbs to be right scrolled. * small styling and position adjustments. * Adjusting right border * Adjusted aria labels, minor alignment details, cleaning up. * adjusting * Adjusting * Adjusting details * clean up, PL adjustments * approving patternlab * Adjusting background color * Adjusting mobile * approving backstop * shrink spacing above page header * adjust spacing * bring breadcrumb into page template * bring breadcrumb into page template * adjust spacing * bring breadcrumb into page template * bring breadcrumb into page template * add breadcrumb to all page and templates * update data * add breadcrumb data to all pages * update breadcrumb on topic page * fix duplicate * Adjusting for PL * Adjusting for fractions and adding a timeout * Adjusting breadcrumbs mobile * Cleaning up for PL * Patternlab/dp 23982 breadcrumb accessibility fix (#1590) * change section to div * remove wrongful hidden settings * add current page * fix * wip * update button description * add changelog * Update packages/patternlab/styleguide/source/_patterns/03-organisms/by-template/breadcrumbs.twig * approve backstop * adding home icon Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> Co-authored-by: beto-aveiga <luis.aveiga@gmail.com> Co-authored-by: Tom Fleming <tom@lastcallmedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions
Description
Places breadcrumbs and relationship indicators for mobile.
Related Issue / Ticket
Steps to Test
Screenshots
Use something like licecap to capture gifs to demonstrate behaviors.
Additional Notes:
Anything else to add?
Impacted Areas in Application
@todo
Today I learned...