Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFMLPB-3476 [portal] nanoid to 3.1.31 #1605

Merged

Conversation

sheldon-b
Copy link
Contributor

@sheldon-b sheldon-b commented Mar 16, 2022

Description

Switch from the deprecated shortid library to nanoid in order to resolve a vulnerability warning.

Related Issue / Ticket

Steps to Test

N/A

Screenshots

N/A

Additional Notes:

I wasn't sure how to test this change. The README gives commands for testing but they don't work. The only testing I did was run npm run start and click through the changed components.

It was confusing that the React package's README suggests using npm install but the base repo seems to have been converted to use Rush for dependency management.

Impacted Areas in Application

  • TabContainer
  • UtilityNav

@sheldon-b
Copy link
Contributor Author

sheldon-b commented Mar 16, 2022

I ran eslint --fix on the files I changed and it introduced several formatting changes -- let me know if you don't want those included. They seemed like improvements to me 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants