-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 8.3.0 #282
Merged
Merged
Release 8.3.0 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DP-10502: Adding ButtonFixedFeedback component * DP-10502: changelog
* add primary and secondary theme to button search * refactor button classes using classNames * append classes * remove override * cleanup scss * set button search primary and secondary styles * wip * fix border styles of button search in header search * add primary/secondary usage to button search * add button search as secondary in patternlab * set buttonSearch usage in header search * fix responsiveness * set header search button to secondary * concat custom classes with a space at the end * update screenshots * fix patternlab header search button * fix header search mobile vertical alignment * add changelog
…198) * DP-10057: Initial pass at tooltip component * DP-10057: Adding question mark svg * DP-10057: Adjusting for svg icon and test language * DP-10057: Correcting linting errors * DP-10057: Adding reference images * DP-10057: Minor data and style changes * DP-10057: Updating spacing in tooltip reference * DP-10057: Adding questionmark to icon component * DP-10057: Removing questionmark component * DP-10057: replacing question mark icon * DP-10057: Updating backstop images. * DP-10057: Updating changelog * DP-10057: Removed other icons from index build * DP-10057: re-adding questionmark icon to story * DP-10057: General teaser backstop approve. * DP-10057: Refactor how icon is passed. * DP-10057: Updating to use global scss * DP-10057: Adding knobs and options to story.
* wip * wip * clean up all conditional rendering in story * clean up filterbox index * clean up searchbanner postinputfilter data * clean up searchbanner * wip * clean up * space out filters fields * add changelog * update screenshots * update changelog * add unique keys to filter fields * fix filterbox story * export forms styles to fix input styles * Adds validation for filters, puts back in filter loop. * Adds comments to utility function usage. * lint fix * add comments * remove unused lines in typecheck
* wip * wip * clean up all conditional rendering in story * clean up filterbox index * clean up searchbanner postinputfilter data * clean up searchbanner * wip * clean up * space out filters fields * add changelog * update screenshots * update changelog * add unique keys to filter fields * fix filterbox story * export forms styles to fix input styles * Adds validation for filters, puts back in filter loop. * Adds comments to utility function usage. * lint fix * add comments * update filterbox desktop hidden class * add destop-hidden to post input filter in filterbox * hide post input filter in header search * approve mobile screenshots * add distance select into filterbox in index.js * Revert "add distance select into filterbox in index.js" This reverts commit 0792eae. * add changelog * update changelog
* fix lint errors * fix * npm lint * last attempt :( * fix value text unmatch
avrilpearl
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.3.0 (9/28/2018)
Added
.ma__button-search
and secondary.ma__button-search--secondary
usage themes to button search add primary and secondary theme to button search #261Fixed
Changed
Note: This will need to be followed up in search and other apps consuming FilterBox / SearchBanner