Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-9485 Mayflower release process v2 #47

Merged
merged 6 commits into from
Jul 17, 2018

Conversation

mrossi113
Copy link
Contributor

Description

While in the process of the release noticed a few changes were needed in the release docs

Related Issue / Ticket

Steps to Test

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@mrossi113 mrossi113 self-assigned this Jul 12, 2018
@mrossi113 mrossi113 changed the title changes per a release yesterday DP-9485-mayflower-release-process-v2 Jul 12, 2018
@mrossi113 mrossi113 changed the title DP-9485-mayflower-release-process-v2 DP-9485 Mayflower release process v2 Jul 12, 2018
@mrossi113
Copy link
Contributor Author

I need to work on this still by creating more documentation for the release.

@mrossi113
Copy link
Contributor Author

@clairesunstudio @rbayliss just want to give you guys a heads up I was looking at the folder structure and noticed a DP-9017.txt was in the following folder paths:

patternlab/styleguide/source/_patterns/03-organisms/by-template/DP-9017.txt
patternlab/styleguide/public/assets/patterns/03-organisms/by-template/DP-9017.txt (next release this should be fixed)

It looks like something from the old Mayflower repository that got merge in a while back https://github.com/massgov/mayflower-patternlab/pull/850/files

I will remove it in the PR and make sure to add it to the Release 5.29.0 in the changlog file. massgov/mayflower-patternlab#866

Copy link
Contributor

@yriahi yriahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yriahi yriahi merged commit 247e07e into develop Jul 17, 2018
@yriahi yriahi deleted the DP-9485-mayflower-release-process-v2 branch July 17, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants