Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patternlab/Add class for GTM #504

Merged

Conversation

clairesunstudio
Copy link
Contributor

@clairesunstudio clairesunstudio commented Mar 11, 2019

Patch
Added
(Patternlab) [OrganizationNavigation] DP-12928: Add link list specific classes: ma__org-nav-i-want-to__findService, ma__org-nav-i-want-to__learnAbout,ma__org-nav-i-want-to__login to sections for GTM. #504

Jira

To track organization subnav menu use, we need unique class identifiers such that we can differentiate between "Find a service or task", "Learn more about", and "Log in to" in Google Tag Manager.

Example org pages with different subnav menu configurations:
https://www.mass.gov/orgs/civil-service
https://www.mass.gov/orgs/massachusetts-supreme-judicial-court

Right now, the three sections in org-sub-nav.png all have ma__org-nav-i-want-to-section as a class. This ticket is done when these three sections have different classes.

@clairesunstudio clairesunstudio changed the title Patternlab/Add class for GTA Patternlab/Add class for GTM Mar 12, 2019
Copy link
Contributor

@mrossi113 mrossi113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! This will need a Drupal PR to be implemented into production.

@mrossi113 mrossi113 merged commit 73d3a2a into develop Mar 13, 2019
@mrossi113 mrossi113 deleted the patternlab/DP-12928-add-class-for-org-subnav-menu-gta branch March 13, 2019 13:20
@clairesunstudio clairesunstudio mentioned this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants