Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patternlab/DP-1379 add focus styles #524

Merged
merged 15 commits into from
May 16, 2019

Conversation

clair0917
Copy link
Contributor

Description

Add focus states to match hover states to header search and topic pages

Related Issue / Ticket

Steps to Test

  1. Open the topics page: http://localhost:3000/patterns/05-pages-topic/05-pages-topic.html
    Tab focus to the header search form and button. The button focus now matches the hover state.
    Tab through the page to see that the decorated links and section links have focus states that match the hover states.

Screenshots

Screen Shot 2019-04-04 at 3 08 49 PM
Screen Shot 2019-04-04 at 3 09 03 PM
Screen Shot 2019-04-04 at 3 09 12 PM

@ygannett
Copy link
Contributor

ygannett commented Apr 5, 2019

LGTM.
Once the circle ci errors area resolved, it's ready to merge.

Copy link
Contributor

@ygannett ygannett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@ygannett ygannett merged commit 14dac3b into develop May 16, 2019
@clairesunstudio clairesunstudio mentioned this pull request May 29, 2019
@avrilpearl avrilpearl deleted the patternlab/DP-1379--add-focus-styles branch June 27, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants