DP-16804 State organizations link in Utility Nav #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnschumann
suggested changes
Jan 26, 2020
There was a problem hiding this comment.
This worked fine when I pulled the branch into Drupal and tested. When I viewed the branch locally in Mayflower, "State Organizations" does not appear (confirmed this also at https://mayflower.digital.mass.gov/b/patternlab/DP-16804_state-organizations-link/index.html). This is because in patternlab/styleguide/source/_data/utilityNav.json, line 26, "links" is empty:
"links": ""
Once I added an array of link info to utilityNav.json "href": "#", I can see "State Organizations" in the menu in Mayflower.
lynnschumann
suggested changes
Jan 26, 2020
….com:massgov/mayflower into patternlab/DP-16804_state-organizations-link
|
@lynnschumann Thank you for the note. utilityNav.json has been updated. Please review again. |
….com:massgov/mayflower into patternlab/DP-16804_state-organizations-link
a-username
approved these changes
Jan 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions
Description
Change the state organizations menu from a button to a link directly to the page.
Related Issue / Ticket
Steps to Test
Screenshots
Desktop
Mobile
Additional Notes:
Anything else to add?
Impacted Areas in Application
@todo
Today I learned...