Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/dp 17064 allow semantic versioning #908

Merged
merged 11 commits into from
Jan 28, 2020

Conversation

clairesunstudio
Copy link
Contributor

@clairesunstudio clairesunstudio commented Jan 24, 2020

Added impact field in changelog template to control semantic versioning:

#___IMPACT___
# - Major impact when you make incompatible API changes,
# - Minor impact when you add functionality in a backwards compatible manner, and
# - Patch impact when you make backwards compatible bug fixes.
# See https://semver.org/ for more info.

CHANGE TYPE - [see list above]:
  - project: [enter a valid project prefix - see list above]
    component: [enter a valid component name - see direction above]
    description: Describe the change. If you need multiple lines, start the first line with the following "|-" characters. (#PR)
    issue: [add a Jira ticket or issue number, e.g. DP-12345 or 124]
    impact: [enter a valid impact, e.g. Minor]

Test logic:

  • check out efb73dd
  • change the impact value in changelogs/test.yml

If there's a Major:
Screen Shot 2020-01-24 at 2 54 45 PM

If there's a Minor:
Screen Shot 2020-01-24 at 2 54 40 PM

If there are only Patches:
Screen Shot 2020-01-24 at 2 54 47 PM

Copy link
Member

@rbayliss rbayliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This works for me.

@rbayliss rbayliss merged commit a4409ba into develop Jan 28, 2020
@rbayliss rbayliss deleted the automation/DP-17064-allow-semantic-versioning branch January 28, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants