Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ram action not showing critical hit on result of 20+ #1681

Open
compcon opened this issue Sep 20, 2021 · 0 comments · May be fixed by #1700
Open

[BUG] Ram action not showing critical hit on result of 20+ #1681

compcon opened this issue Sep 20, 2021 · 0 comments · May be fixed by #1700
Labels
bug Something isn't working rules A mistake in the implementation of LANCER rules triage Requires Review
Milestone
Active Game Mode

Comments

@compcon
Copy link

compcon commented Sep 20, 2021

Submitted At: 9/19/2021 19:43:38

Issue:
The Ram action is not showing a critical hit on a roll of 20+. Ram is triggered by a melee attack. (pg 70), Brutal II: Cull the Herd grants knockback I on all critical hits. This may also interact with the damage from Caliban's Slam ability or Juggernaut II: Kinetic Mass Transfer

Massif Reference: Core book, pages 70, 91
@compcon compcon added bug Something isn't working rules A mistake in the implementation of LANCER rules triage Requires Review labels Sep 20, 2021
msprijatelj added a commit to msprijatelj/compcon that referenced this issue Oct 1, 2021
@msprijatelj
fix(Active Mode): enable Critical Hit text for Rams
2d1e83f 
This change borrows some Critical Hit decorators from `_WeaponAttack.vue` to indicate when a Ram is
a critical hit.

Closes massif-press#1681
@msprijatelj msprijatelj linked a pull request Oct 1, 2021 that will close this issue
Draft
1 task
@jarena3 jarena3 added this to the Active Game Mode milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rules A mistake in the implementation of LANCER rules triage Requires Review
Projects
None yet
Milestone
Active Game Mode
Development

Successfully merging a pull request may close this issue.

fix(Active Mode): enable Critical Hit text for Rams msprijatelj/compcon
2 participants
@jarena3 @compcon