Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Raise max thread count #203

Closed
6 tasks done
GamerDude27 opened this issue Sep 17, 2020 · 3 comments
Closed
6 tasks done

[Enhancement] Raise max thread count #203

GamerDude27 opened this issue Sep 17, 2020 · 3 comments
Labels
enhancement New feature or request tc2 Only related to Team Comtress 2

Comments

@GamerDude27
Copy link

GamerDude27 commented Sep 17, 2020

Description

With PR #141 came the famous ValveSoftware/source-sdk-2013#436 fix, but one thing is missing.
The original poster also additionally proposes raising MAX_THREADS and MAX_TOOLS_THREADS from 16 to 32, maybe even 64 like in Q3A, so my question is, would this be relevant for TC2?

Checklist

  • None of the open or closed issues document this idea.
  • This is a new idea, not a bug.
  • This idea does not seriously affect game balance.
  • This idea is for the code of the game, not for textures, sounds, or other resources.
  • This is not an idea for new game content (e.g. new weapons, maps, sounds).
  • This is obviously an improvement, not something that people commonly disagree on.
@GamerDude27 GamerDude27 added enhancement New feature or request needs triage Needs to be organized tc2 Only related to Team Comtress 2 labels Sep 17, 2020
@maximsmol maximsmol removed the needs triage Needs to be organized label Sep 17, 2020
@maximsmol
Copy link
Contributor

Some notes:

This might have already been done. I think the max thread count fluctuates between TC2 releases

Until we fix threading this is not gonna give any real performance boost

@treacherousfiend
Copy link

I think max threads is either unlimited or 32, but right now the game can't really do too much with said threads.

@mastercoms
Copy link
Member

Maximum threads should be no more than 64 (32 cores when hyperthreading), because threading anything more will break a lot of assumptions about locality because of NUMA nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tc2 Only related to Team Comtress 2
Projects
None yet
Development

No branches or pull requests

4 participants