VRAD: Fix thread-sharing bug #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercoms
requested changes
Sep 15, 2020
|
Just in raytrace, or in float_bm4 too? |
|
Also, the original code doesn't work as-intended because it isn't an atomic int and the raytracing system is multithreaded. I can also go ahead and change that too. |
GamerDude27
suggested changes
Sep 15, 2020
|
Out of curiosity, is the |
|
Additionally, the linked PR also proposes upping |
mastercoms
approved these changes
Sep 17, 2020
|
@GamerDude27 Please move the MAX_THREADS discussion to a new issue, thanks! |
|
@mastercoms I'm still curious about my first question though! |
6 tasks
|
rip bro @devvoid |
mastercoms
added a commit
that referenced
this pull request
Oct 7, 2020
This reverts commit 0d63ec8.
mastercoms
added a commit
that referenced
this pull request
Oct 8, 2020
This reverts commit 4267429.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raytracing code has debug variable
n_intersection_calculations. This was used solely for debugging, but its existence caused a massive bottleneck in VRAD; performance nearly doubles on some systems without it.More information and some performance testing can be found here: ValveSoftware/source-sdk-2013#436