Adding support for linux/darwin for Powershell function #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterzen
reviewed
May 2, 2021
| process = "powershell.exe" | ||
| } | ||
| // Linux // MacOS | ||
| if runtime.GOOS == "linux" || runtime.GOOS == "darwin" { |
There was a problem hiding this comment.
I'm not sure I get the rationale here. The executable to launch is dependent on the target platform not the platform where the winrm client is running, or did I miss something ?
| // Specify pwsh to run encoded command | ||
| process = "pwsh" | ||
| } | ||
| return process + " -EncodedCommand " + psCmd |
There was a problem hiding this comment.
Also, if you change the command, then you'll have at least to change the accompanying unit test in powershell_test.go.
|
Scratch that....you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #117