Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of total leaves of a BranchSpot #10

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Number of total leaves of a BranchSpot #10

merged 3 commits into from
Mar 9, 2023

Conversation

stefanhahmann
Copy link
Collaborator

resolves #9

@stefanhahmann stefanhahmann self-assigned this Dec 19, 2022
@stefanhahmann stefanhahmann changed the title Issue 9 Number of total leaves of a BranchSpot Jan 4, 2023
maarzt
maarzt reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@maarzt maarzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "BranchNLeavesFeature" seems useful.

The number of "BranchNSubBranchSpotsFeature" is mostly a duplication of the BranchNLeavesFeater and could be removed.

Both FeatureComputers should be implemented using the "DepthFirstSearch" class.

src/main/java/org/mastodon/mamut/feature/branch/BranchNLeavesFeature.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNLeavesFeatureComputer.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeature.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeatureComputer.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeatureSerializer.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeatureComputer.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeatureComputer.java Outdated Show resolved Hide resolved
src/main/java/org/mastodon/mamut/feature/branch/BranchNSubBranchSpotsFeature.java Outdated Show resolved Hide resolved
maarzt
maarzt previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@maarzt maarzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the changes we made during in the coding session. Everything else is all good now ❤️

Only one thing: The IntPropertyFeatureSerializer should get a more honest name, maybe BranchSpotIntPropertyFeatureSerializer.

@stefanhahmann
Add new features BranchNLeavesFeature and BranchNSuccessorsFeature
dba1bc4 
* BranchNLeavesFeature represents the total number of leaves of a branch spot in its subtree.
* BranchNSuccessorsFeature represents the total number of successors of a branch spot in its subtree.
@stefanhahmann
Copy link
Collaborator Author

Please include the changes we made during in the coding session. Everything else is all good now ❤️

Pushed theses changes.

Only one thing: The IntPropertyFeatureSerializer should get a more honest name, maybe BranchSpotIntPropertyFeatureSerializer.

Changed it.

@stefanhahmann stefanhahmann merged commit 9fe03c0 into master Mar 9, 2023
@stefanhahmann stefanhahmann mentioned this pull request Aug 10, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarzt maarzt maarzt left review comments

Assignees

@stefanhahmann stefanhahmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of total leaves of a BranchSpot
2 participants
@stefanhahmann @maarzt