Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable dendrogram panel #98

Merged
merged 21 commits into from
May 8, 2024
Merged

Configurable dendrogram panel #98

merged 21 commits into from
May 8, 2024

Conversation

stefanhahmann
Copy link
Collaborator

@stefanhahmann stefanhahmann commented Apr 16, 2024 •
edited
Loading

Resolves #100

@stefanhahmann stefanhahmann force-pushed the configurable_dendrogram_panel branch 2 times, most recently from acfca72 to ae6e1b9 Compare April 25, 2024 11:19
@stefanhahmann stefanhahmann self-assigned this Apr 25, 2024
@stefanhahmann stefanhahmann force-pushed the configurable_dendrogram_panel branch 3 times, most recently from 0ac7660 to edd2daa Compare April 25, 2024 12:36
@stefanhahmann stefanhahmann force-pushed the configurable_dendrogram_panel branch from cc5c934 to eae551d Compare May 3, 2024 10:20
maarzt
maarzt previously approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@maarzt maarzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a functional test that included all the new checkboxes / settings in the DendogramView and the export function. It all worked flawlessly 👍. Very nice!

@stefanhahmann
Add new demo DendrogramViewDemo
8757906
@stefanhahmann
Move generation of sample data from DendrogramPanelDemo to ClusterData
9abb7b7 
* Allows reusing the classification in other demo classes
@stefanhahmann
Consider the cases of null params in method getTagLabel
0a7cc5b
@stefanhahmann
Include a mapping between cluster nodes and objects represented by th…
0dcb1a0 
…em to the Classification class

* This allows to manipulate the labels of the leaves in the resulting dendrogram
@stefanhahmann
Remove the possibility to set the tag set to be used to label the den…
806b338 
…drogram from the ClusterRootNodesController
@stefanhahmann
Change ui text in case of no classification data in the DendrogramPanel
2098371
@stefanhahmann
Remove unrequired empty DendrogramPanel constructor
f70d46c
@stefanhahmann
Add possibility to toggle on/off median and threshold line in the den…
cfa3678 
…drogram panel
@stefanhahmann
Remove class BranchSpotTreeWithExtraLabel and instead add a sub class…
0c6ba6c 
… label supplier to BranchSpotTree

* Configuring the label of a BranchSpotTree can now be done with the new label supplier
@stefanhahmann
Add Model to DendrogramView
8862118
@stefanhahmann
Add method to manipulate the leaf labeling to the DendrogramPanel
8d9c691
@stefanhahmann
Split creating, returning and setting the layout of the canvas of the…
ce0277c 
… DendrogramView into separate methods
@stefanhahmann
Add checkboxes to DendrogramView that allow to toggle median/threshol…
2c3a199 
…d line in the dendrogram on/off
@stefanhahmann
Add possibility to change the labeling of the leave nodes in the clas…
9c55b4b 
…sification dendrogram

* Root labels on/off
* Tag set on/off
* Choose tag set
@stefanhahmann
Adapt the default height of the DendrogramView to the height needed t…
594911c 
…o display the DendrogramPanel
@stefanhahmann
Use the pref service to persist settings made by the user in the dend…
c086972 
…rogram view
@stefanhahmann
Adapt display width and height of DendrogramPanel in case of no class…
641c849 
…ification

* Since no dendrogram is show in this case, the Borders of the Dendrogram do not need to be considered
@stefanhahmann
Extend DendrogramPanelTest to cover more of the new settable features
ed08727
@stefanhahmann
Add testUpdateClusterNames() to ClassificationTest
82d051a
@stefanhahmann stefanhahmann force-pushed the configurable_dendrogram_panel branch from eae551d to a3f15be Compare May 8, 2024 13:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanhahmann stefanhahmann merged commit 41b2180 into master May 8, 2024
3 checks passed
@stefanhahmann stefanhahmann deleted the configurable_dendrogram_panel branch May 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarzt maarzt maarzt left review comments

Assignees

@stefanhahmann stefanhahmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable dendrogram panel
2 participants
@stefanhahmann @maarzt