Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use confirmation dialog before erasing draft to reply to new status #878

Closed
esnyder opened this issue Apr 4, 2017 · 12 comments
Closed

Use confirmation dialog before erasing draft to reply to new status #878

esnyder opened this issue Apr 4, 2017 · 12 comments
Labels
bug Something isn't working

Comments

@esnyder
Copy link

esnyder commented Apr 4, 2017

This is the sort of thing that you presumably get trained out of pretty fast, but it's kind of annoying the first few times it happens.

If you start writing something in the "What is on your mind" edit box on the left, and then notice someone says something you want to respond to, and you hit the little 'Reply' arrow under their toot, your existing text is discarded with no undoo possible (as far as I can tell.)

@offbyone
Copy link
Contributor

offbyone commented Apr 7, 2017

A popover to reply would not be a bad idea.

@ashfurrow ashfurrow added the bug Something isn't working label Apr 22, 2017
@ashfurrow
Copy link
Contributor

I've had this too when I've started typing and decide to turn it into a reply to an earlier toot, so they're chained.

@Irick
Copy link

Irick commented Apr 24, 2017

I've had this pattern bite me in the buns a few times as well.
Distractions make me forget I have something in the buffer, or I forget I already had a tweet in the respond slot and I lose my artful masterpiece D:

@thirdtruck
Copy link

Happened to me today and then almost a second time to the same toot draft.

Adding a "Are you sure you want to delete this draft?" pop-up would be a nice stopgap measure.

Having a queue of drafts (with new ones opened above existing drafts) might be even better.

@ashfurrow
Copy link
Contributor

Definitely a queue of drafts would be ideal, @thirdtruck would you mind opening a GitHub issue for that?

I like your stopgap solution, I think using the new confirmation modal would be nice too.

@Gargron Gargron changed the title Replying to a toot causes you to lose whatever you had been composing. Use confirmation dialog before erasing draft to reply to new status Jun 29, 2017
@rakiru
Copy link

rakiru commented Nov 7, 2017

I missed this issue and posted a duplicate. I've closed it, so here's what I said:

Type a toot, but don't send it, then hit reply on another toot. Your unsent toot is deleted with no confirmation or way to recover it. While this is as a result of a user action, it's also easy to do accidentally or absent-mindedly. A user may also intentionally do this if they're used to websites with inline replies, such as reddit.

There should be a(n optional?) confirmation along the lines of "You have an unsent toot. Are you sure you want to delete it?" if there is any text in the compose box.

(I typed out a whole introduction post, was trying to think if I was missing anything, went to reply to another toot quickly, and lost my post)

@kit-ty-kate
Copy link

Any news on this ?

@SoniEx2
Copy link

SoniEx2 commented Jan 16, 2018

I think the current toot should always carry over unless it's empty.

@kit-ty-kate
Copy link

kit-ty-kate commented Mar 14, 2018

Sorry to up this again but it has been two months and I got stung again. Anybody working on this ?
Or maybe any documentation to understand the source code to maybe try to fix this ?

@saper
Copy link
Contributor

saper commented Aug 5, 2018

There are different things people want here. And definitely a dialog modal popup is to be avoided at all costs. For some, #6249 they want to preserve the text because they just change from just tooting to a reply.

For others, like deciding to reply to someone instead of composing something it is a completely different thing. They wouldn't want to preserve their previous thing. (Or yes, maybe preserve, but not send to someone else by accident).

@ricardusvincencius
Copy link

ricardusvincencius commented Sep 24, 2018

I have been in a situation where I had just written a complete (near 500 chr) toot, and then something popped up in notifications, and my brain went "OOOH!!! SHINY!!!" and I clicked reply, and lost all that i had written. I would definitely want to save the original text.

@mvz
Copy link

mvz commented Oct 5, 2018

This even happens when clicking reply, typing your reply, then hitting the same reply button again.

ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Oct 5, 2018
Gargron pushed a commit that referenced this issue Oct 5, 2018
…t empty (#8893)

* Add a confirmation dialog when hitting reply and the compose box isn't empty

Fixes #878

* Performance improvement
hannahwhy pushed a commit to hannahwhy/mastodon that referenced this issue Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests