Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty poll options not being filtered on remote poll update #12484

Merged
merged 1 commit into from
Nov 26, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/activitypub/process_poll_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def call(poll, json)

voters_count = @json['votersCount']

latest_options = items.map { |item| item['name'].presence || item['content'] }
latest_options = items.map { |item| item['name'].presence || item['content'] }.compact

# If for some reasons the options were changed, it invalidates all previous
# votes, so we need to remove them
Expand Down