add S3_READ_TIMEOUT environment variable #14952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Oct 6, 2020
|
Suggestion: should we consider different max timeout with different file sizes? For example we should wait 20 seconds to upload a video but shouldn't wait more than 5 secon for a image. |
|
I don't think the timeout value should be determined by the file size. I just want set enough timeout value that might not happen in successful case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
tootctl media removeor media upload from WebUI or client,I saw many
Net::ReadTimeout with #<TCPSocket:(closed)>.5s default value is too short for cheap storage service.
This PR add S3_READ_TIMEOUT environment variable to configure read timeout.
See also: #12459