Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize some regex matching #15528

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Optimize some regex matching #15528

merged 4 commits into from
Jan 22, 2021

Conversation

007lva
Copy link
Contributor

@007lva 007lva commented Jan 10, 2021 •
edited
Loading

Regexp#match? is faster and more proper when only matters if the regex matches or not.

https://bigbinary.com/blog/ruby-2-4-implements-regexp-match-without-polluting-global-variables

@007lva 007lva changed the title Use Regex#match? Optimize some regex matching Jan 10, 2021
Base automatically changed from master to main January 20, 2021 10:31
@007lva
Copy link
Contributor Author

007lva commented Jan 22, 2021

Hello, is there something I can do to get this merged?

@Gargron Gargron merged commit eb51e43 into mastodon:main Jan 22, 2021
@007lva 007lva deleted the refactor/optimizations-using-regex-match branch January 22, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@007lva @Gargron