Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization of cold-start follow recommendations #17479

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix localization of cold-start follow recommendations #17479

merged 1 commit into from
Feb 8, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 7, 2022 •
edited
Loading

  • Use current locale (allows customization with Add global locale param #17464)
  • Display language-specific results before global results, since otherwise global ones always overshadow
  • Fix cold-start follow recommendations being generated for locales that will never get results due to regional locale codes

@Gargron Gargron added bug Something isn't working new user experience Features for attracting and onboarding new users labels Feb 7, 2022
@Gargron Gargron merged commit 35850f8 into main Feb 8, 2022
@Gargron Gargron deleted the fix-follow-recommendations-locale branch February 8, 2022 00:53
Gargron added a commit that referenced this pull request Feb 8, 2022
@Gargron
Fix error in suggestions API due to typo
3aaea2c 
Regression from #17479
@Gargron Gargron mentioned this pull request Feb 8, 2022
Merged
Gargron added a commit that referenced this pull request Feb 8, 2022
@Gargron
Fix error in suggestions API due to typo (#17486)
2adcad0 
Regression from #17479
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
@Gargron @jesseplusplus
Fix localization of cold-start follow recommendations (mastodon#17479)
c591aac
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
@Gargron @jesseplusplus
Fix error in suggestions API due to typo (mastodon#17486)
f0d07fe 
Regression from mastodon#17479
@ahox ahox mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working new user experience Features for attracting and onboarding new users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ykzts