Change “Only people I mention” to “Mentioned people only” #18291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
May 3, 2022
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
May 4, 2022
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18146 changed the string
privacy.direct.shortfrom “Direct” to “Only people I mention”, but that change wasn't done in a consistent way (sorry I didn't catch that earlier), as in a place (app/javascript/mastodon/components/status.js, for tooltips), it has been changed to “Mentioned people only”.It would be possible to use two different strings, but “Mentioned people only” works in both contexts, and none of the other dropdown options refer to the user in using the first person.