Make handle more easily selectable on profile page #21479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadars
commented
Nov 23, 2022
|
There is a small issue when the account is locked, in which there will be an additional space and an icon at the end. Could you perhaps add another Otherwise this is a very good improvement! |
|
Cool, I've wrapped the handle in a span and corrected the CSS as well. Let me know if that works for you! |
ClearlyClaire
approved these changes
Nov 25, 2022
connorshea
approved these changes
Nov 27, 2022
|
@cadars Thank you so much for this extremely useful pull request! I think merge is blocked by the whitespace in this blank line, right? I hope this gets merged soon (though I have already patched my instance). |
|
@evanphilip Oops. Should be fixed now! |
ClearlyClaire
approved these changes
Dec 13, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* Make handle more easily selectable on profile page * Wrap handle in a span * Add `user-select: all` to span * remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.