Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up on MoveWorker spec #25528

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

mjankowski
Copy link
Contributor

Reduces spec run time from ~17s to ~9s, and reduces DB queries in spec from ~15,400 to ~11,100.

There are probably more improvements to be found in this one, but it's all pretty deeply nested and this was the most obvious low hanging fruit for a first pass.

Good future work here could include:

  • Look at whether the block/mute shared example could be combined with the followers one (they are always called together)
  • Look through the various permutations of shared example nesting and identify which ones do/dont need all the data created, and try to isolate that better. There are almost definitely examples here creating way more data then they need, but its hard to sort out with the nesting.

Reduces spec run time from ~17s to ~9s, and reduces DB queries in spec
from ~15,400 to ~11,100.

There are probably more improvements to be found in this one, but it's
all pretty deeply nested and this was the most obvious low hanging fruit
for a first pass.
@renchap renchap added ruby Pull requests that update Ruby code testing Automated lint and test suites labels Jun 20, 2023
@ClearlyClaire ClearlyClaire merged commit cad8cc9 into mastodon:main Oct 13, 2023
@mjankowski mjankowski deleted the spec-workers-move-queries branch October 13, 2023 14:04
audiodude pushed a commit to audiodude/mastodon that referenced this pull request Oct 23, 2023
000hen pushed a commit to thenapnetwork/nap-mastodon that referenced this pull request Dec 6, 2023
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Dec 14, 2023
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code testing Automated lint and test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants