Convert dropdown_menu state to Typescript
#25585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @takayamaki if you have some suggestions or comments on the way I did it! |
renchap
force-pushed
the
typescript-dropdownmenu-state
branch
from
95e4594 to
7ddcc8e
Compare
ykzts
approved these changes
Jul 11, 2023
takayamaki
approved these changes
Aug 7, 2023
This was referenced Aug 19, 2023
renchap
force-pushed
the
typescript-dropdownmenu-state
branch
from
7ddcc8e to
0023cd4
Compare
Using the proper Redux Toolkit helpers
renchap
force-pushed
the
typescript-dropdownmenu-state
branch
from
0023cd4 to
2ed555d
Compare
ClearlyClaire
approved these changes
Sep 22, 2023
audiodude
pushed a commit
to audiodude/mastodon
that referenced
this pull request
Oct 23, 2023
000hen
pushed a commit
to thenapnetwork/nap-mastodon
that referenced
this pull request
Dec 6, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds over my #25584 PR.
It shows how to convert from the legacy Immutable state to the new Redux Toolkit + Immer state, which work with plain objects.
It features:
mapStateToPropsin JS files