Handle negative offset param in api/v2/search
#28282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
api-param-error-targeted
branch
from
6ecbd5b to
5a52e18
Compare
ClearlyClaire
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As alternative to #28256 this catches the offset error more narrowly just within the search controller, and returns 400 when invalid value present.
I put this directly in search because it's the most specific case ... but probably, this should actually live in the API::Base controller class? I guess the question there is can we safely assume that everywhere across the api that a
params[:offset]is present, we want to check its value this way?