Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update artifact actions (major) to v4 (major) #28415

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 18, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/download-artifact action major v3 -> v4
actions/upload-artifact action major v3 -> v4

Release Notes

actions/download-artifact (actions/download-artifact)

v4

Compare Source

actions/upload-artifact (actions/upload-artifact)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 18, 2023
@mjankowski
Copy link
Contributor

We had previously done some artificact upload/download optimization to work around a speed issue on the old version of this. It will be interesting to see how much of a speedup we see on top of that -- but it's always been a bit variable so we need multiple runs to confirm (they were very fast on this one run connected to the PR: 0s, 1s, etc).

ClearlyClaire
ClearlyClaire previously approved these changes Dec 20, 2023
@ClearlyClaire ClearlyClaire dismissed their stale review December 20, 2023 09:13

reports of intermitent errors on github's side, needs more investigation

@renchap
Copy link
Member

renchap commented Dec 20, 2023

There seem to be problems with this new version, and this is investigated on Github's side.

See actions/download-artifact#249

@renovate renovate bot changed the title Update artifact actions (major) to v4 (major) Update actions/download-artifact action to v4 Jan 9, 2024
@renovate renovate bot changed the title Update actions/download-artifact action to v4 Update artifact actions (major) to v4 (major) Jan 9, 2024
@ClearlyClaire
Copy link
Contributor

The action has been updated to retry downloading for up to 5 times on error: actions/download-artifact#274
If that is good enough for us, we can update; but I have not seen any information on the underlying issue.

@renovate renovate bot changed the title Update artifact actions (major) to v4 (major) chore(deps): update artifact actions (major) to v4 (major) Jan 22, 2024
Copy link
Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can go with it, and revert back if this proves to cause too many random failures.

@renchap renchap added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 559bbf0 Jan 24, 2024
33 checks passed
@renchap renchap deleted the renovate/major-artifact-actions-(major) branch January 24, 2024 16:51
neatchee pushed a commit to neatchee/mastodon that referenced this pull request Feb 4, 2024
* Add confirmation when redirecting logged-out requests to permalink (mastodon#27792)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* chore(deps): update dependency rubocop to v1.60.1 (mastodon#28731)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix `Rails/WhereExists` cop in app/lib (mastodon#28862)

* Use active variants for boost icons and increase icon size (mastodon#27924)

* chore(deps): update dependency haml_lint to v0.55.0 (mastodon#28856)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency selenium-webdriver to v4.17.0 (mastodon#28858)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update artifact actions (major) to v4 (major) (mastodon#28415)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency dotenv to v16.4.0 (mastodon#28872)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chewy to v7.5.0 (mastodon#28730)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Tidy up association declaration in `Instance` model (mastodon#28880)

* Fix process of receiving posts with bearcaps is not working (mastodon#26527)

* Fix redirect confirmation for accounts (mastodon#28902)

* Add tests for redirect confirmations (mastodon#28903)

* Add tests for processing statuses using bearcap URIs (mastodon#28904)

* chore(deps): update dependency rspec-rails to v6.1.1 (mastodon#28905)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency axios to v1.6.6 (mastodon#28895)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix remaining `Rails/WhereExists` cop violations, regenerate todo (mastodon#28892)

* fix(deps): update dependency dotenv to v16.4.1 (mastodon#28889)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add `CustomFilterKeyword#to_regex` method (mastodon#28893)

* New Crowdin Translations (automated) (mastodon#28899)

Co-authored-by: GitHub Actions <noreply@github.com>

* Consolidate db test prep steps to rake task (mastodon#28886)

* Fix `Style/TernaryParentheses` cop (mastodon#28387)

* Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (mastodon#28361)

* Extract helper methods for db connection and table existence check in `CLI::Maintenance` task (mastodon#28281)

* Refactor conversations components in web UI (mastodon#28833)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Fix `Style/GuardClause` cop in app/controllers (mastodon#28420)

* Update paperclip and climate_control gems (mastodon#28379)

* Extract `rebuild_index` method in maintenance CLI (mastodon#28911)

* Add specs for `Instance` model scopes and add `with_domain_follows` scope (mastodon#28767)

* [Glitch] Add confirmation when redirecting logged-out requests to permalink

Port SCSS changes from b19ae52 to glitch-soc

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* [Glitch] Use active variants for boost icons and increase icon size

Port 5a838ce to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* Fix CSS loading in redirect controller

* [Glitch] Refactor conversations components in web UI (glitch-soc#2589)

Port 3205a65 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Fix crash in private mention conversations in glitch-soc flavor (glitch-soc#2595)

* Remove obsolete locale file (glitch-soc#2596)

* Add github action workflow for manual security builds (mastodon#29040)

* Adapt workflow to glitch-soc

* Fix missing `workflow_dispatch` trigger for `build-security` (mastodon#29041)

* Configure selenium to use Chrome version 120 (mastodon#29038)

* Fix security builds not being marked latest

* Merge pull request from GHSA-3fjr-858r-92rw

* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1

* Fix build-security workflow for glitch-soc

* Restore -streaming suffix for security builds (glitch-soc#2602)

* Temporary hack to correctly tag the security docker image…

* Fix build-security docker tags

* fix lint issues in conversation.jsx

---------

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matt Jankowski <matt@jankowski.online>
Co-authored-by: KMY(雪あすか) <tt@kmycode.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Aaron Brady <aaron@insom.me.uk>
neatchee added a commit to neatchee/mastodon that referenced this pull request Feb 4, 2024
* Add confirmation when redirecting logged-out requests to permalink (mastodon#27792)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* chore(deps): update dependency rubocop to v1.60.1 (mastodon#28731)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix `Rails/WhereExists` cop in app/lib (mastodon#28862)

* Use active variants for boost icons and increase icon size (mastodon#27924)

* chore(deps): update dependency haml_lint to v0.55.0 (mastodon#28856)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency selenium-webdriver to v4.17.0 (mastodon#28858)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update artifact actions (major) to v4 (major) (mastodon#28415)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency dotenv to v16.4.0 (mastodon#28872)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chewy to v7.5.0 (mastodon#28730)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Tidy up association declaration in `Instance` model (mastodon#28880)

* Fix process of receiving posts with bearcaps is not working (mastodon#26527)

* Fix redirect confirmation for accounts (mastodon#28902)

* Add tests for redirect confirmations (mastodon#28903)

* Add tests for processing statuses using bearcap URIs (mastodon#28904)

* chore(deps): update dependency rspec-rails to v6.1.1 (mastodon#28905)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency axios to v1.6.6 (mastodon#28895)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix remaining `Rails/WhereExists` cop violations, regenerate todo (mastodon#28892)

* fix(deps): update dependency dotenv to v16.4.1 (mastodon#28889)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add `CustomFilterKeyword#to_regex` method (mastodon#28893)

* New Crowdin Translations (automated) (mastodon#28899)

Co-authored-by: GitHub Actions <noreply@github.com>

* Consolidate db test prep steps to rake task (mastodon#28886)

* Fix `Style/TernaryParentheses` cop (mastodon#28387)

* Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (mastodon#28361)

* Extract helper methods for db connection and table existence check in `CLI::Maintenance` task (mastodon#28281)

* Refactor conversations components in web UI (mastodon#28833)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Fix `Style/GuardClause` cop in app/controllers (mastodon#28420)

* Update paperclip and climate_control gems (mastodon#28379)

* Extract `rebuild_index` method in maintenance CLI (mastodon#28911)

* Add specs for `Instance` model scopes and add `with_domain_follows` scope (mastodon#28767)

* [Glitch] Add confirmation when redirecting logged-out requests to permalink

Port SCSS changes from b19ae52 to glitch-soc

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* [Glitch] Use active variants for boost icons and increase icon size

Port 5a838ce to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* Fix CSS loading in redirect controller

* [Glitch] Refactor conversations components in web UI (glitch-soc#2589)

Port 3205a65 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Fix crash in private mention conversations in glitch-soc flavor (glitch-soc#2595)

* Remove obsolete locale file (glitch-soc#2596)

* Add github action workflow for manual security builds (mastodon#29040)

* Adapt workflow to glitch-soc

* Fix missing `workflow_dispatch` trigger for `build-security` (mastodon#29041)

* Configure selenium to use Chrome version 120 (mastodon#29038)

* Fix security builds not being marked latest

* Merge pull request from GHSA-3fjr-858r-92rw

* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1

* Fix build-security workflow for glitch-soc

* Restore -streaming suffix for security builds (glitch-soc#2602)

* Temporary hack to correctly tag the security docker image…

* Fix build-security docker tags

---------

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matt Jankowski <matt@jankowski.online>
Co-authored-by: KMY(雪あすか) <tt@kmycode.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Aaron Brady <aaron@insom.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants