Add coverage/bugfix for invalid appeal submission #28703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28703 +/- ##
=======================================
Coverage 84.83% 84.84%
=======================================
Files 1038 1038
Lines 28142 28142
Branches 4536 4536
=======================================
+ Hits 23874 23876 +2
+ Misses 3103 3101 -2
Partials 1165 1165 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the appeals controller runs here, the view path does not find this file but does find an application/_card partial (in view path all the time) and currently errors out on an invalid data submission.
Spec here exposes the issue, code change is to just be explicit about the partial and not rely on view path since we potentially use it from multiple controllers.