Added check for STATSD_ADDR setting to emit a warning and proceed rather than crashing if the address is unreachable #30691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than crashing if the address is unreachable
|
Related #30240 |
ClearlyClaire
changed the title
ClearlyClaire
approved these changes
Jun 21, 2024
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 1, 2024
…her than crashing if the address is unreachable (mastodon#30691)
ClearlyClaire
pushed a commit
that referenced
this pull request
Jul 2, 2024
…her than crashing if the address is unreachable (#30691)
ClearlyClaire
pushed a commit
that referenced
this pull request
Jul 2, 2024
…her than crashing if the address is unreachable (#30691)
ClearlyClaire
pushed a commit
that referenced
this pull request
Jul 2, 2024
…her than crashing if the address is unreachable (#30691)
nomad-geek
pushed a commit
to dftba-club/mastodon
that referenced
this pull request
Jul 3, 2024
…her than crashing if the address is unreachable (mastodon#30691)
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Jul 4, 2024
…her than crashing if the address is unreachable (mastodon#30691)
noellabo
pushed a commit
to fedibird/mastodon
that referenced
this pull request
Jul 5, 2024
…her than crashing if the address is unreachable (mastodon#30691)
ttrace
pushed a commit
to ttrace/mastodon
that referenced
this pull request
Jul 5, 2024
…her than crashing if the address is unreachable (mastodon#30691)
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Jul 5, 2024
…her than crashing if the address is unreachable (mastodon#30691)
fono09
pushed a commit
to fono09/mastodon
that referenced
this pull request
Jul 5, 2024
…her than crashing if the address is unreachable (mastodon#30691)
atsu1125
pushed a commit
to atsu1125/mastodon
that referenced
this pull request
Jul 6, 2024
…her than crashing if the address is unreachable (mastodon#30691)
noellabo
pushed a commit
to fedibird/mastodon
that referenced
this pull request
Sep 9, 2024
…her than crashing if the address is unreachable (mastodon#30691)
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
…her than crashing if the address is unreachable (mastodon#30691)
noellabo
pushed a commit
to fedibird/mastodon
that referenced
this pull request
Sep 19, 2024
…her than crashing if the address is unreachable (mastodon#30691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30622
The code that initializes
statsdfatally crashes if the value ofSTATSD_ADDRis not a resolvable name/address. This change rescues that exception and instead emits it as a warning, sincestatsdis an optional configuration.