Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lists to reflect added and removed users retroactively #32930

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Change lists to reflect added and removed users retroactively #32930

merged 1 commit into from
Nov 19, 2024

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 16, 2024 •
edited
Loading

Add users' posts into lists after adding them, and remove upon removing. Makes lists usable right away instead of having to wait for people to publish a new post.

Fix #16290, fix #13687

@Gargron Gargron force-pushed the feature-backfill-list-timelines branch 4 times, most recently from 7f1e5df to 822e9ad Compare November 16, 2024 17:14
@Gargron Gargron force-pushed the feature-backfill-list-timelines branch from 822e9ad to df82868 Compare November 16, 2024 17:36
@renchap renchap requested a review from a team November 18, 2024 17:35
ClearlyClaire
ClearlyClaire reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review it more thoroughly, but I think this does not remove replies from list members to accounts that have just been removed from the list.

@ClearlyClaire
Copy link
Contributor

I need to review it more thoroughly, but I think this does not remove replies from list members to accounts that have just been removed from the list.

That being said, this is not new and I think the same issue occurs in the Home timeline. So this can safely be considered separately.

oneiros
oneiros reviewed Nov 19, 2024
View reviewed changes
app/workers/merge_worker.rb Show resolved Hide resolved
app/workers/unmerge_worker.rb Show resolved Hide resolved
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 2b5faa2 Nov 19, 2024
27 checks passed
@ClearlyClaire ClearlyClaire deleted the feature-backfill-list-timelines branch November 19, 2024 10:12
@ClearlyClaire ClearlyClaire mentioned this pull request Nov 19, 2024
Merged
@vmstan vmstan mentioned this pull request Nov 23, 2024
Open
rezhajulio added a commit to PegelinuxTop/mastodon that referenced this pull request Nov 26, 2024
@rezhajulio @mjankowski
@renchap @tribela @renovate @github-actions @web-flow @ThisIsMissEm @Gargron @drwl @shleeable @ClearlyClaire @PauloVilarinho @c960657 @Joshix-1
Merge upstream (#52)
52b903a 
* Remove remnants of embed views (mastodon#32419)

* Use `with_options` blocks in `Associations` concern (mastodon#32840)

* Add OpenTelemetry VCS attributes (mastodon#32904)

* Add missing autofocus on boost modal (mastodon#32953)

* Update libretranslate/libretranslate Docker tag to v1.6.2 (mastodon#32951)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @formatjs/cli to v6.3.11 (mastodon#32950)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#32927)

Co-authored-by: GitHub Actions <noreply@github.com>

* `Form::Import` spec reduce factories (mastodon#32924)

* Reduce long lines in `relationships/show` view (mastodon#32922)

* Extract constants for controller `LIMIT` queries (mastodon#32921)

* Update dependency aws-sdk-s3 to v1.171.0 (mastodon#32901)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Use `nil` instead of `false` for datetime value in spec (mastodon#32926)

* Streaming: add development logging of database queries (mastodon#32945)

* Fix `min_id` and `max_id` causing error in search API (mastodon#32857)

* Move self destruct check to `config_for` and add constant for verifier string (mastodon#32943)

* Change dependency from annotate to annotaterb (mastodon#30232)

* Use hash arguments to `select` when possible (Rails 7.2) (mastodon#32917)

* Use hash arguments to `order` when possible (Rails 7.2) (mastodon#32915)

* Add coverage for fixing the thing with the dates in the search area (mastodon#32958)

* Prep work for coverage addition to `ActivityPub::DeliveryWorker` spec (mastodon#32944)

* Use group/count approach in annual report classes (mastodon#32914)

* DB Replica database_tasks as ENV (mastodon#32908)

* Fix notification polling showing a loading bar in web UI (mastodon#32960)

* Update dependency aws-sdk-s3 to v1.172.0 (mastodon#32964)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#32969)

Co-authored-by: GitHub Actions <noreply@github.com>

* Add `LoginActivity` model spec and `BrowserDetection` concern shared example (mastodon#32959)

* Extract `Notification::Groups` concern (mastodon#32968)

* Change lists to reflect added and removed users retroactively (mastodon#32930)

* Use hash arguments to `group` when possible (mastodon#32916)

* Fix error when viewing statuses to deleted replies in moderation view (mastodon#32986)

* Update dependency opentelemetry-instrumentation-rails to '~> 0.33.0' (mastodon#32987)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add `AccountWarning` case to `Report#history` spec (mastodon#32984)

* New Crowdin Translations (automated) (mastodon#32990)

Co-authored-by: GitHub Actions <noreply@github.com>

* Update dependency json-schema to v5.1.0 (mastodon#32992)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix posts made in the future being allowed to trend (mastodon#32996)

* Add ability to middle-mouse click posts in web UI (mastodon#32988)

* block scheduled status from frozen users (mastodon#30729)

* Fix wrong video dimensions for some rotated videos (mastodon#33008)

* New Crowdin Translations (automated) (mastodon#33010)

Co-authored-by: GitHub Actions <noreply@github.com>

* Update dependency doorkeeper to v5.8.0 (mastodon#33000)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add stop-gap antispam code (mastodon#32981)

* `rel="me"` check should be case-insenstive (mastodon#32238)

* Change design of lists in web UI (mastodon#32881)

* Fix duplicate notifications in notification groups when using slow mode (mastodon#33014)

* improve nginx.conf by setting gzip_static to on (mastodon#30698)

* LinkDetailsExtractor adjustments (mastodon#31357)

* Fix pushing hashtag-followed posts to feeds of inactive users (mastodon#33018)

* Rely on Rails to enable YJIT when available (mastodon#33017)

* Update Yarn to v4.5.2 (mastodon#33021)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#33020)

Co-authored-by: GitHub Actions <noreply@github.com>

* Update dependency aws-sdk-s3 to v1.173.0 (mastodon#33019)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [Glitch] Add missing autofocus on boost modal

Port 60801ab to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* [Glitch] Fix notification polling showing a loading bar in web UI

Port e856838 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* Set autofocus on favourite modal (glitch-soc#2900)

* New Crowdin Translations (automated) (glitch-soc#2896)

* New Crowdin translations

* Fix bogus no.yml

* Fix bogus simple_form.no.yml

---------

Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* [Glitch] Fix duplicate notifications in notification groups when using slow mode

Port 4bfb888 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* Remove pinned accounts editor

It was utterly broken and the underlying modals are getting redesigned

* [Glitch] Change design of lists in web UI

Port 6260350 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>

* Fix issue templates (glitch-soc#2904)

---------

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Matt Jankowski <matt@jankowski.online>
Co-authored-by: Renaud Chaput <renchap@gmail.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Andrew W. Lee <wjldrew@gmail.com>
Co-authored-by: Shlee <github@shl.ee>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Paulo Vilarinho <33267902+PauloVilarinho@users.noreply.github.com>
Co-authored-by: Christian Schmidt <github@chsc.dk>
Co-authored-by: Joshix-1 <57299889+Joshix-1@users.noreply.github.com>
@trwnh trwnh mentioned this pull request Nov 26, 2024
Closed
@mjankowski mjankowski mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

@oneiros oneiros oneiros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New lists should get populated with existing toots Lists do not update even when relationship is updated
3 participants
@Gargron @ClearlyClaire @oneiros