Update to emojimart 2.6.1 #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP using local updated version. Sheet comes from emoji-data@4.0.4, file sheet_twitter_32_indexed_256.png.
renatolond
commented
Jun 6, 2018
| const { uncompress: emojiMartUncompress } = require('emoji-mart/dist/utils/data'); | ||
| let data = require('emoji-mart/data/all.json'); | ||
| if(data.compressed) { | ||
| data = emojiMartUncompress(data); |
There was a problem hiding this comment.
I'm not sure this whole if is needed. When I was developing I saw the compressed version of the file, but since then I'm only seeing the uncompressed and I don't know if it's some weird caching.
|
I don't know how @nolanlawson generated app/javascript/mastodon/features/emoji/emoji_map.json, I believe it probably needs to be regenerated for this update 🤔 |
|
This will partially solve #5579 (it updates to unicode 10. Seems like emoji mart does not support 11 yet). |
Gargron
approved these changes
Jun 7, 2018
lawremipsum
pushed a commit
to lawremipsum/mspsocial-mastodon
that referenced
this pull request
Jul 7, 2018
* Update to emojimart 2.6.1 WIP using local updated version. Sheet comes from emoji-data@4.0.4, file sheet_twitter_32_indexed_256.png. * Update to 2.6.1 and uncompress data if needed * Remove changes that were not needed * Fix yarn lock file * Match emojiToShowFilter behavior to new version of emoji-mart * Fix codeclimate issue * Match custom emoji behavior to new version of emoji-mart * Replace emoji without shortcode in tests * Fix code climate issues
handholdinginc
pushed a commit
to handholdinginc/social
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sheet comes from emoji-data@4.0.4, file sheet_twitter_32_indexed_256.png.