Migrate to go mod #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat
requested changes
Dec 9, 2020
There was a problem hiding this comment.
Thank you @korbenclario for this PR and congratulations to your first PR ! 😃
I quickly tested this and it works great. Just one thing seems broken: the task that combines the NOTICES file from all dependencies: make update_notices_file now creates an empty NOTICES file. This is using the licensed tool, configured in the .licensed.yml. Could you have a brief look into this?
mat
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier development and using up-to-date tools, I've migrated this repo to
go modules.Please, review and tell me if there is something to discuss.
.gitignorefor developing in IDE and on iOS