Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for svg icons #52

Merged
merged 6 commits into from
Feb 26, 2021
Merged

support for svg icons #52

merged 6 commits into from
Feb 26, 2021

Conversation

gurgeous
Copy link
Contributor

How about this? SVGs are added with width/height 9999 so they sort to the top. IconFinder always prefers SVGs. Also added a FORMATS env variable. Feedback welcome, this isn't set in stone.

Copy link
Owner

@mat mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just a couple of comments, but I like the overall approach and execution, straightforward 👍

besticon/besticon.go Outdated Show resolved Hide resolved
Readme.markdown Show resolved Hide resolved
besticon/besticon.go Show resolved Hide resolved
@mat mat merged commit 48d272c into mat:master Feb 26, 2021
@gurgeous gurgeous deleted the svg branch February 26, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants